From a2a4b6ce0207bdb08f30b7d3182b4a074d50e600 Mon Sep 17 00:00:00 2001 From: Matěj Cepl Date: Sat, 28 May 2011 16:57:05 +0200 Subject: Make closing bug as UPSTREAM working again. Actually, wholeURL must be initialized and wholeURL is string, not an object which would have host property). Fixes #102 --- data/rhlib/rhbzpage.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'data/rhlib/rhbzpage.js') diff --git a/data/rhlib/rhbzpage.js b/data/rhlib/rhbzpage.js index 99cd276..070737e 100644 --- a/data/rhlib/rhbzpage.js +++ b/data/rhlib/rhbzpage.js @@ -378,12 +378,16 @@ function addClosingUpstream() { "external_id"); if (inputBox.value.match(/^http.*/)) { - externalBugID = getBugNoFromURL(inputBox.value); + wholeURL = inputBox.value; + // TODO this is probably midlly ineffective ... we do parseURL here, + // and getBugNoFromURL does it as well. + externalBugID = getBugNoFromURL(wholeURL); if (externalBugID) { inputBox.value = externalBugID; } // get bugzillaName and set the label - var bugzillaName = getBugzillaName(wholeURL.host, constantData.bugzillaLabelNames); + var bugzillaName = getBugzillaName(parseURL(wholeURL).host, + constantData.bugzillaLabelNames); selectOptionByLabel("external_id", bugzillaName); } else if (!isNaN(inputBox.value)) { -- cgit