From 775cf3d628588ede2ddee8346bf8b58dcfd8dde0 Mon Sep 17 00:00:00 2001 From: Matěj Cepl Date: Wed, 16 Feb 2011 18:50:43 +0100 Subject: Remove whole ifExist magic, it is not necessary anymore anyway. * add also protection to queryUpstream function for situation when constantData.queryUpstreamBug structure is not present. --- data/rhbzpage.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'data/rhbzpage.js') diff --git a/data/rhbzpage.js b/data/rhbzpage.js index d12b4a1..ce0d3fd 100644 --- a/data/rhbzpage.js +++ b/data/rhbzpage.js @@ -81,8 +81,7 @@ function setDefaultAssignee() { createNewButton("bz_assignee_edit_container",true, { "name": "Def. Assignee", "assignee": "default" - }); // TODO when this will be a production we can remove - // rh-common/setDefaultAssignee from RH_Data-packages.json + }); } } @@ -491,6 +490,10 @@ function queryUpstreamCallback(text) { * @return none */ function queryUpstream() { + if (!constantData.queryUpstreamBug) { + alert("We don't have constantData.queryUpstreamBug set up!"); + return null; + } var text = getSelection(); if (!text) { postMessage(new Message("GetClipboard", "queryUpstream")); @@ -655,7 +658,6 @@ function fillInChipMagic(XorgLogAttList, XorgLogAttListIndex) { replace(/[\s"]+/g," ").trim(); // that.packages["rh-xorg"].chipMagic.chipMagic = interestingLine+"\t"+interestingArray[1] // .toUpperCase(); - // TODO we can remove rh-common / chipMagic element from RH_Data-packages.json createNewButton("status_whiteboard", true, { "name": "Fill In", "chipMagic": true -- cgit