From 80e1f1983de30b3bed630b703aab6660830ae711 Mon Sep 17 00:00:00 2001
From: Matěj Cepl <mcepl@redhat.com>
Date: Wed, 13 Jan 2010 00:22:47 +0100
Subject: Add some FIXMEs

---
 bugzillaBugTriage.js | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

(limited to 'bugzillaBugTriage.js')

diff --git a/bugzillaBugTriage.js b/bugzillaBugTriage.js
index ec6efd9..d262d33 100644
--- a/bugzillaBugTriage.js
+++ b/bugzillaBugTriage.js
@@ -523,7 +523,7 @@ BzPage.prototype.serializeForm = function (form) {
     function serializeControl(element) {
         var val = element.value;
         console.log("val.toSource() = " + val.toSource());
-        /* FIXME what is element with type="select-one" ??? 
+        /*
         on  HTMLSelectElement we have an attribute 'type' of type DOMString, readonly
             The type of this form control. This is the string "select-multiple"
             when the multiple attribute is true and the string "select-one" when
@@ -1083,6 +1083,10 @@ BzPage.prototype.sendBugUpstream = function() {
     text += this.collectComments();
     jetpack.clipboard.set(text);
     var ret = jetpack.tabs.open(url);
+    // TODO ret is yet another jetpack.tabs member, so
+    // ret.contentDocument should work. We can directly
+    // prepopulate b.m.o form instead of messing with
+    // the clipboard.
     console.log("opening new tab returned");
     console.log(ret);
 };
@@ -1109,9 +1113,6 @@ BzPage.prototype.parseAttachmentLine = function (inElem) {
     // getting name of the attachment
     var attName = inElem.getElementsByTagName("b")[0].textContent.trim();
 
-    // getting id
-    // $("a:contains('Details')", inElem);
-    // FIXME isn't there more simple way to replace above? querySelector?
     var aHrefsArr = inElem.getElementsByTagName("a");
     var aHref = Array.filter(aHrefsArr,function (x) {
         return x.textContent.trim() == "Details";
@@ -1317,13 +1318,12 @@ BzPage.prototype.fixAttachById = function(id,type,email) {
     this.reqCounter++;
 };
 
+// FIXME possibly eliminate this function altogether and
+// make it inline?
 BzPage.prototype.fixAllAttachments = function(list) {
-    var tmpElem = {};
-
-    for(var i=0;i<list.length;i++) {
-        tmpElem = list[i];
-        this.fixAttachById(tmpElem[1]);
-    }
+    Array.forEach(list,function (x) {
+        this.fixAttachById(x[1]);
+    }, this);
 };
 
 /**
-- 
cgit