From bd26ab13b7d8e89eccb684f374959cfedbe51de7 Mon Sep 17 00:00:00 2001 From: Matěj Cepl Date: Tue, 7 Jun 2011 00:53:09 +0200 Subject: And even chip magic now works with new Attachment objects. --- data/lib/otherButtons.js | 6 ++++-- data/rhlib/addAttachmentRow.js | 1 - data/rhlib/rhbzpage.js | 4 +--- lib/main.js | 1 + 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/data/lib/otherButtons.js b/data/lib/otherButtons.js index ea5f67b..6935b8e 100644 --- a/data/lib/otherButtons.js +++ b/data/lib/otherButtons.js @@ -95,7 +95,7 @@ function addingEmbelishments(logList) { && (!FillMagicDoneRE.test(getSummary())) && (maintCCAddr == "xgl-maint@redhat.com")) { // Add find chip magic button - fillInChipMagic(logList[0][1]); + fillInChipMagic(logList[0].id); } // Add links for creating new bug in the same product @@ -114,9 +114,11 @@ function addingEmbelishments(logList) { * String with the IsueTracker numbers * @return none */ -function setBranding(atts) { +function setBranding(things) { var brandColor = {}; var TriagedColor = {}; + + var atts = things.attachments; var xLogAtts = atts.getXorgList(); var ITbutton = document.getElementById("cf_issuetracker"); diff --git a/data/rhlib/addAttachmentRow.js b/data/rhlib/addAttachmentRow.js index 63babcd..c8724e3 100644 --- a/data/rhlib/addAttachmentRow.js +++ b/data/rhlib/addAttachmentRow.js @@ -6,7 +6,6 @@ function addAttachmentCallback(resp) { var newAttachID = parseInt( resp.params.param.value.array.data.value.int, 10); - console.log("attachID = " + newAttachID); // FIXME callback.call(param, newAttachID, data.length); } diff --git a/data/rhlib/rhbzpage.js b/data/rhlib/rhbzpage.js index 121885e..abb5c19 100644 --- a/data/rhlib/rhbzpage.js +++ b/data/rhlib/rhbzpage.js @@ -162,7 +162,6 @@ function RHcentralCommandDispatch(cmdLabel, cmdParams) { * @return none */ function sendBugUpstream(thgs) { - console.myDebug("sendBugUpstream: thgs = " + thgs); if (thgs) { localThings = thgs; return; @@ -226,7 +225,6 @@ function fillInChipMagic(XlogID) { function chipsetMagic (interestingLineArr) { // parse Xorg.0.log var cardStr = ""; - console.myDebug("interestingLineArr[1] = " + interestingLineArr[1]); if (interestingLineArr.length >0) { var interestingArray = interestingLineArr[0]; @@ -470,7 +468,7 @@ function RHBZinit(things) { // Just add a link to every Xorg.0.log link analyzing it. things.attachments.addCheckXorgLogLink(); - setBranding(things.attachments); + setBranding(things); // Don't allow to submit a page which would change the bug to 0xFFFF component document.forms.namedItem("changeform").addEventListener( diff --git a/lib/main.js b/lib/main.js index a48f515..4db620a 100644 --- a/lib/main.js +++ b/lib/main.js @@ -214,3 +214,4 @@ contextMenu.Item({ require("clipboard").set(comment); } }); +//tabs.open("https://bugzilla.redhat.com/show_bug.cgi?id=710548"); -- cgit