From 92421b51663ce34939fee936ddcbeec91a67bced Mon Sep 17 00:00:00 2001 From: Matěj Cepl Date: Mon, 2 May 2011 21:59:55 +0200 Subject: "all" keyword in enabledPackages configuration didn't work. Bad use of Array.slice. Fixes #89 --- lib/libbugzilla.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/libbugzilla.js b/lib/libbugzilla.js index aa2d0b7..a1792ea 100644 --- a/lib/libbugzilla.js +++ b/lib/libbugzilla.js @@ -171,11 +171,10 @@ exports.getInstalledPackages = function getInstalledPackages(locationLoginObj, c } } - var allIdx = null; if ((allIdx = enabledPackages.indexOf("all")) != -1) { - enabledPackages = enabledPackages.splice(allIdx, - Object.keys(config.gJSONData.commentPackages)); + enabledPackages.splice(allIdx, 1); + enabledPackages = enabledPackages.concat(Object.keys(config.gJSONData.commentPackages)); } // TODO To be decided, whether we cannot just eliminate packages in -- cgit