From 775cf3d628588ede2ddee8346bf8b58dcfd8dde0 Mon Sep 17 00:00:00 2001
From: Matěj Cepl <mcepl@redhat.com>
Date: Wed, 16 Feb 2011 18:50:43 +0100
Subject: Remove whole ifExist magic, it is not necessary anymore anyway.

 * add also protection to queryUpstream function for situation when
   constantData.queryUpstreamBug structure is not present.
---
 bugs/issue-4b0135b3f8d3675913978d8cf258a28dd9dabb3d.yaml | 11 +++++++++--
 data/bzpage.js                                           |  8 --------
 data/rhbzpage.js                                         |  8 +++++---
 3 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/bugs/issue-4b0135b3f8d3675913978d8cf258a28dd9dabb3d.yaml b/bugs/issue-4b0135b3f8d3675913978d8cf258a28dd9dabb3d.yaml
index 2543afd..f7678ec 100644
--- a/bugs/issue-4b0135b3f8d3675913978d8cf258a28dd9dabb3d.yaml
+++ b/bugs/issue-4b0135b3f8d3675913978d8cf258a28dd9dabb3d.yaml
@@ -8,8 +8,8 @@ type: :task
 component: bugzilla-triage
 release: 
 reporter: Matej Cepl <mcepl@redhat.com>
-status: :unstarted
-disposition: 
+status: :closed
+disposition: :fixed
 creation_time: 2011-02-14 12:05:04.006931 Z
 references: []
 
@@ -23,4 +23,11 @@ log_events:
   - Matej Cepl <mcepl@redhat.com>
   - commented
   - also line 669 in fillInChipMagic
+- - 2011-02-16 17:50:14.228537 Z
+  - Matej Cepl <mcepl@redhat.com>
+  - closed with disposition fixed
+  - |-
+    Isn't need anymore, with relation to {issue e389bd396f38d67898a3e6cdb1315c4df5f2ef0d} almost fixed,
+    we can do it much more easily just by passing the command to the button
+    instead of playing with false indexes.
 trac_id: 
diff --git a/data/bzpage.js b/data/bzpage.js
index 208f64f..872f4f1 100644
--- a/data/bzpage.js
+++ b/data/bzpage.js
@@ -348,14 +348,6 @@ function createNewButton (location, after, cmdObj) {
         return ;
     }
 
-    // creation of button might be conditional on existence of data in constantData
-    if ("ifExist" in cmdObj) {
-        // We do have constantData now, but we shouldn't TODO
-        if (!(cmdObj.ifExist in constantData)) {
-            return ;
-        }
-    }
-
     var newButton = document.createElement("input");
     newButton.setAttribute("id", newId);
     newButton.setAttribute("type", "button");
diff --git a/data/rhbzpage.js b/data/rhbzpage.js
index d12b4a1..ce0d3fd 100644
--- a/data/rhbzpage.js
+++ b/data/rhbzpage.js
@@ -81,8 +81,7 @@ function setDefaultAssignee() {
         createNewButton("bz_assignee_edit_container",true, {
             "name": "Def. Assignee",
             "assignee": "default"
-        }); // TODO when this will be a production we can remove
-        // rh-common/setDefaultAssignee from RH_Data-packages.json
+        });
     }
 }
 
@@ -491,6 +490,10 @@ function queryUpstreamCallback(text) {
  * @return none
  */
 function queryUpstream() {
+    if (!constantData.queryUpstreamBug) {
+        alert("We don't have constantData.queryUpstreamBug set up!");
+        return null;
+    }
     var text = getSelection();
     if (!text) {
         postMessage(new Message("GetClipboard", "queryUpstream"));
@@ -655,7 +658,6 @@ function fillInChipMagic(XorgLogAttList, XorgLogAttListIndex) {
                         replace(/[\s"]+/g," ").trim();
                     // that.packages["rh-xorg"].chipMagic.chipMagic = interestingLine+"\t"+interestingArray[1]
                     //    .toUpperCase();
-                    // TODO we can remove rh-common / chipMagic element from RH_Data-packages.json
                     createNewButton("status_whiteboard", true, {
                         "name": "Fill In",
                         "chipMagic": true
-- 
cgit