From 6b739e89d0fa88899d680d09bbc7bcbd2628de31 Mon Sep 17 00:00:00 2001 From: Matěj Cepl Date: Sun, 24 Apr 2011 23:43:49 +0200 Subject: Don't allow marking bug as triaged when it doesn't have severity set. --- data/lib/bugzillaDOMFunctions.js | 9 +++++++++ data/lib/otherButtons.js | 9 +++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/data/lib/bugzillaDOMFunctions.js b/data/lib/bugzillaDOMFunctions.js index 0f22020..8392b87 100644 --- a/data/lib/bugzillaDOMFunctions.js +++ b/data/lib/bugzillaDOMFunctions.js @@ -202,6 +202,15 @@ function getSummary() { return document.getElementById("short_desc_nonedit_display").textContent; } +/** + * Get the current title of the bug + * + * @return string + */ +function getSeverity() { + return document.getElementById("bug_severity").value; +} + /** * Get the current email of the reporter of the bug. * diff --git a/data/lib/otherButtons.js b/data/lib/otherButtons.js index 2f93ea7..7bd36f3 100644 --- a/data/lib/otherButtons.js +++ b/data/lib/otherButtons.js @@ -62,12 +62,17 @@ function markBugTriaged() { // /fedora-meeting.2009-11-24-15.11.log.html if (!hasXorgBugsCategory()) { alert("This won't do! First set the category!"); - } else { + } + else if (getSeverity() == 'unspecified') { + alert("This won't do! Specify some severity!"); + } + else { addStuffToTextBox("keywords","Triaged"); } } - var FillMagicDoneRE = new RegExp("^\\s*\\[[0-9a-zA-Z_]*\\]"); +var FillMagicDoneRE = new RegExp("^\\s*\\[[0-9a-zA-Z_]*\\]"); + function addingEmbelishments(list) { var maintCCAddr = ""; -- cgit