From 655dcd3b809c80ca6ca2ae001202064dd594df2b Mon Sep 17 00:00:00 2001 From: Matěj Cepl Date: Tue, 1 Jun 2010 01:27:07 +0200 Subject: Adding unit tests for xmlrpc.js --- lib/rhbzpage.js | 6 ++++-- lib/xmlrpc.js | 2 +- tests/test-xmlrpc.js | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 37 insertions(+), 3 deletions(-) create mode 100644 tests/test-xmlrpc.js diff --git a/lib/rhbzpage.js b/lib/rhbzpage.js index b007982..f318528 100644 --- a/lib/rhbzpage.js +++ b/lib/rhbzpage.js @@ -4,6 +4,8 @@ // http://www.opensource.org/licenses/mit-license.php "use strict"; var utilMod = require("util"); +var xrpc = require("xmlrpc"); +var xhr = require("xhr"); // var TriagedDistro = 13; // var NumberOfFrames = 7; // var XMLRPCurl = "https://bugzilla.redhat.com/xmlrpc.cgi"; @@ -641,7 +643,7 @@ RHBugzillaPage.prototype.fillInChipMagic = function () { attURL = "https://bugzilla.redhat.com/attachment.cgi?id="+XorgLogAttID; that = this; - let req = new XMLHttpRequest(); + let req = new xhrMod.XMLHttpRequest(); req.open("GET",attURL,true); req.onreadystatechange = function (aEvt) { if (req.readyState == 4) { @@ -888,7 +890,7 @@ RHBugzillaPage.prototype.fixAttachById = function(id, type, email) { email = false; } - let msg = new XMLRPCMessage("bugzilla.updateAttachMimeType"); + let msg = new xrpc.XMLRPCMessage("bugzilla.updateAttachMimeType"); msg.addParameter( { 'attach_id' : id, 'mime_type' : type, diff --git a/lib/xmlrpc.js b/lib/xmlrpc.js index 2b264e7..69bb77e 100644 --- a/lib/xmlrpc.js +++ b/lib/xmlrpc.js @@ -15,7 +15,7 @@ * */ -exports.XMLRPCMessage = function XMLRPCMessage(methodname) { +var XMLRPCMessage = exports.XMLRPCMessage = function XMLRPCMessage(methodname) { this.method = methodname || "system.listMethods"; this.params = []; return this; diff --git a/tests/test-xmlrpc.js b/tests/test-xmlrpc.js new file mode 100644 index 0000000..afb78c5 --- /dev/null +++ b/tests/test-xmlrpc.js @@ -0,0 +1,32 @@ +/*global exports: false, require: false */ +/*jslint plusplus: false */ +"use strict"; +var xrpc = require("xmlrpc"); +var xmlOut = "\n" + + "\nbugzilla.updateAttachMimeType\n" + + "\n\n\n\nattach_id\n" + + "myId\n\n\n" + + "mime_type\ntext/plain\n\n" + + "\nnomail\nbillg@microsoft.com" + + "\n\n\n\n\n\n" + + "me@example.com\n\n" + + "\nsecret\n\n" + + "\n3.14\n\n" + + "\n1\n\n" + + "\n"; + +// testing xrpc.XMLRPCMessage +exports.ensureGenerateXMLRPC = function (test) { + var msg = new xrpc.XMLRPCMessage("bugzilla.updateAttachMimeType"); + msg.addParameter({ + 'attach_id' : "myId", + 'mime_type' : "text/plain", + 'nomail' : "billg@microsoft.com" + }); + msg.addParameter("me@example.com"); + msg.addParameter("secret"); + msg.addParameter(3.14); + msg.addParameter(true); + test.assertEqual(msg.xml(), xmlOut, + "generate XML-RPC message"); +}; -- cgit