From 2a8cfd4c1b55125d3211694496cea35cc9603ff9 Mon Sep 17 00:00:00 2001
From: Matěj Cepl <mcepl@redhat.com>
Date: Thu, 5 May 2011 12:02:51 +0200
Subject: Make the script more reliable against JSON-hosting sites being down.

Fixes #92
---
 data/lib/otherButtons.js | 8 ++++----
 lib/libbugzilla.js       | 2 ++
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/data/lib/otherButtons.js b/data/lib/otherButtons.js
index a766668..6bcc043 100644
--- a/data/lib/otherButtons.js
+++ b/data/lib/otherButtons.js
@@ -113,9 +113,9 @@ function addingEmbelishments(list) {
   }
 
   // TODO Get compiz bugs as well
-  if ((constantData.chipNames) && (list[0])
+  if ((new Boolean(constantData.chipNames)) && (list[0].length > 0)
       && (!FillMagicDoneRE.test(getSummary()))
-      && (maintCCAddr === "xgl-maint@redhat.com")) {
+      && (maintCCAddr == "xgl-maint@redhat.com")) {
     // Add find chip magic button
     var whiteboard_string = document
         .getElementById("status_whiteboard").value;
@@ -197,8 +197,8 @@ function setBranding(xLogAtts) {
   var compElems;
   if (config.suspiciousComponents
       && isInList(getComponent(), config.suspiciousComponents)
-      && (compElems = document
-          .getElementById("bz_component_edit_container"))) {
+      && ((compElems = document
+          .getElementById("bz_component_edit_container")))) {
     compElems.style.background = "red none";
   }
 
diff --git a/lib/libbugzilla.js b/lib/libbugzilla.js
index a1792ea..3763eff 100644
--- a/lib/libbugzilla.js
+++ b/lib/libbugzilla.js
@@ -379,6 +379,8 @@ exports.initialize = function initialize(config, callback) {
               onComplete: function(response) {
                 if (response.status == 200) {
                   config.constantData[title] = response.json;
+                } else {
+                  console.error("Cannot download " + title + " from URL " + url);
                 }
               }
             }).get();
-- 
cgit