diff options
author | Matěj Cepl <mcepl@redhat.com> | 2010-07-19 16:52:19 +0200 |
---|---|---|
committer | Matěj Cepl <mcepl@redhat.com> | 2010-07-19 17:46:20 +0200 |
commit | 8db90e886bc25f382145a3af543959021851e5cd (patch) | |
tree | 6b48b8350bb209e686e6ec2d2d076a40ab1bc42b /lib/rhbzpage.js | |
parent | fcfbd3f7f01df5c67182366dc25e41567addc3b8 (diff) | |
download | bugzilla-triage-8db90e886bc25f382145a3af543959021851e5cd.tar.gz |
Allow empty Xorg log analysis
Diffstat (limited to 'lib/rhbzpage.js')
-rw-r--r-- | lib/rhbzpage.js | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/lib/rhbzpage.js b/lib/rhbzpage.js index 340e1fd..f68bf38 100644 --- a/lib/rhbzpage.js +++ b/lib/rhbzpage.js @@ -710,7 +710,7 @@ RHBugzillaPage.prototype.parseAttachmentLine = function(inElem) { RHBugzillaPage.prototype.analyzeXorgLog = function analyzeXorgLog(attachID) { var infoWin = this.win.open("", "Check att. " + attachID, - "width=512,height=640,status=no,location=no"); + "width=640,height=640,status=no,location=no"); var doc = infoWin.document; doc.body.innerHTML = "<pre id='textPre'></pre>"; var preElem = doc.getElementById("textPre"); @@ -720,11 +720,17 @@ RHBugzillaPage.prototype.analyzeXorgLog = function analyzeXorgLog(attachID) { Request({ url: attURL, onComplete: function() { - this.response.text.split("\n").filter(function(line) { + var results = this.response.text.split("\n"). + filter(function(line) { return (that.RE.soughtLines.test(line)); - }).forEach(function(l) { + }); + if (results.length > 0) { + results.forEach(function(l) { preElem.innerHTML += l + "\n"; }); + } else { + preElem.innerHTML += "No matching lines found!"; + } } }).get(); }; @@ -930,7 +936,6 @@ RHBugzillaPage.prototype.markBugTriaged = function() { // for F13 and later, ASSIGNED is "add Triaged keyword" (as well) // for <F13 it is "add both" (ASSIGNED status and Triaged keyword) var ver = this.getVersion(); - console.log("Marking bug as Triaged!"); if ((!this.isEnterprise()) && (ver <= 12)) { this.selectOption("bug_status", "ASSIGNED"); } |