aboutsummaryrefslogtreecommitdiffstats
path: root/data
diff options
context:
space:
mode:
authorMatěj Cepl <mcepl@redhat.com>2011-05-04 17:50:28 +0200
committerMatěj Cepl <mcepl@redhat.com>2011-06-05 14:51:41 +0200
commit4fea7aeaf6dc6f3687662882782658ed4b31e7e3 (patch)
treedbc3eecbf2b15d70657c930323a43ec9cef92812 /data
parent0b92c971cd6887ff7386c0e2a7577440429d47f6 (diff)
downloadbugzilla-triage-4fea7aeaf6dc6f3687662882782658ed4b31e7e3.tar.gz
Make filterByRegexp more tolerant to different configurations.
* filterByRegexp shouldn’t crash when list is undefined * also be more tolerant for nonexistent some RH-specific functions Fixes #91.
Diffstat (limited to 'data')
-rw-r--r--data/lib/otherButtons.js4
-rw-r--r--data/lib/util.js2
2 files changed, 3 insertions, 3 deletions
diff --git a/data/lib/otherButtons.js b/data/lib/otherButtons.js
index 0e7b408..a766668 100644
--- a/data/lib/otherButtons.js
+++ b/data/lib/otherButtons.js
@@ -60,10 +60,10 @@ function markBugTriaged() {
// /fedora-meeting.2009-11-24-15.11.log.html
// http://meetbot.fedoraproject.org/fedora-meeting/2009-11-24\
// /fedora-meeting.2009-11-24-15.11.log.html
- if (!hasXorgBugsCategory()) {
+ if (hasXorgBugsCategory && !hasXorgBugsCategory()) {
alert("This won't do! First set the category!");
}
- else if (!isEnterprise() && (getSeverity() == 'unspecified')) {
+ else if (isEnterprise && !isEnterprise() && (getSeverity() == 'unspecified')) {
alert("This won't do! Specify some severity!");
}
else {
diff --git a/data/lib/util.js b/data/lib/util.js
index 064887c..dc927b6 100644
--- a/data/lib/util.js
+++ b/data/lib/util.js
@@ -294,7 +294,7 @@ function removeCSVValue(str, value) {
*/
function filterByRegexp(list, chosingMark) {
var chosenPair = [];
- if (list.length > 0) {
+ if (list && list.length > 0) {
chosenPair = list.filter(function (pair) {
return new RegExp(pair.regexp, "i").test(chosingMark);
});