aboutsummaryrefslogtreecommitdiffstats
path: root/data/lib
diff options
context:
space:
mode:
authorMatěj Cepl <mcepl@redhat.com>2012-04-11 11:38:06 +0200
committerMatěj Cepl <mcepl@redhat.com>2012-04-11 11:38:06 +0200
commit03a01c78c630251416a6e21ad797158d9d16081b (patch)
treecfdca481801771db29acda4c7d297bc9f1e0dc42 /data/lib
parent3476e68c41e5a106a3f514c411ff93bfe0ad61a4 (diff)
downloadbugzilla-triage-03a01c78c630251416a6e21ad797158d9d16081b.tar.gz
Clean superfluous console.log calls and update HACKING
With debugging switched off the addons should generate nothing on the console.
Diffstat (limited to 'data/lib')
-rw-r--r--data/lib/bugzillaDOMFunctions.js2
-rw-r--r--data/lib/bzpage.js11
-rw-r--r--data/lib/skip-bug.js1
3 files changed, 4 insertions, 10 deletions
diff --git a/data/lib/bugzillaDOMFunctions.js b/data/lib/bugzillaDOMFunctions.js
index be30a3e..ae4b01d 100644
--- a/data/lib/bugzillaDOMFunctions.js
+++ b/data/lib/bugzillaDOMFunctions.js
@@ -198,7 +198,7 @@ function createNewButton (location, after, cmdObj) {
// protection against double-firings
if (document.getElementById(newId)) {
- console.log("Element with id " + newId + " already exists!");
+ console.warning("Element with id " + newId + " already exists!");
return ;
}
diff --git a/data/lib/bzpage.js b/data/lib/bzpage.js
index e44f3f4..9d83e15 100644
--- a/data/lib/bzpage.js
+++ b/data/lib/bzpage.js
@@ -337,7 +337,7 @@ function setConfigurationButton () {
*
*/
function completeInit() {
- // FIXME: add flags, and priority or others bits.
+ // TODO: add flags, and priority or others bits.
var things = {
attachments: new AttachList(document),
comments: new CommentList(document)
@@ -358,13 +358,13 @@ function completeInit() {
function startup() {
// First, preflight check ... if we are not logged in, there
// is nothing we can do.
- console.log("startup: Starting!");
+ myDebug("startup: Starting!");
var logoutLink = Array.some(document.links, function (x) {
return x.search === "?logout=1" ;
});
if (logoutLink) {
if (document.getElementById("brElementPlace_location")) {
- console.error("Hit multiple firing protection!")
+ console.error("Hit multiple firing protection!");
return null; // This should just finish whole content script without
// doing any harm to anybody.
}
@@ -396,11 +396,6 @@ function startup() {
extBugsHeadline.setAttribute("id", "external_bugs_headline");
}
- // TODO Probably could be ignored ... used only once on line 973 of
- // rhbzpage.js
- // if (parseAbrtBacktraces && this.RE.Abrt.test(getSummary())) {
- // title = document.getElementById("short_desc_nonedit_display").textContent;
-
// So, now we know we are logged in, so we can get to
// the real work.
setConfigurationButton();
diff --git a/data/lib/skip-bug.js b/data/lib/skip-bug.js
index 4b4cd34..5597b35 100644
--- a/data/lib/skip-bug.js
+++ b/data/lib/skip-bug.js
@@ -15,5 +15,4 @@ function reloadPage() {
}
}
-console.log("asdasd");
reloadPage();