diff options
author | Matěj Cepl <mcepl@redhat.com> | 2011-05-04 17:50:28 +0200 |
---|---|---|
committer | Matěj Cepl <mcepl@redhat.com> | 2011-05-04 17:50:28 +0200 |
commit | 0d90391317f597d66e6f51520eaf012a6ff3ad10 (patch) | |
tree | 815d01410cf9af33a30afa0748ffce5ab6fdb0f9 /data/lib | |
parent | a83151a1567367bb99014100e890e89681ff206f (diff) | |
download | bugzilla-triage-0d90391317f597d66e6f51520eaf012a6ff3ad10.tar.gz |
Make filterByRegexp more tolerant to different configurations.
* filterByRegexp shouldn’t crash when list is undefined
* also be more tolerant for nonexistent some RH-specific functions
Fixes #91.
Diffstat (limited to 'data/lib')
-rw-r--r-- | data/lib/otherButtons.js | 4 | ||||
-rw-r--r-- | data/lib/util.js | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/data/lib/otherButtons.js b/data/lib/otherButtons.js index 0e7b408..a766668 100644 --- a/data/lib/otherButtons.js +++ b/data/lib/otherButtons.js @@ -60,10 +60,10 @@ function markBugTriaged() { // /fedora-meeting.2009-11-24-15.11.log.html // http://meetbot.fedoraproject.org/fedora-meeting/2009-11-24\ // /fedora-meeting.2009-11-24-15.11.log.html - if (!hasXorgBugsCategory()) { + if (hasXorgBugsCategory && !hasXorgBugsCategory()) { alert("This won't do! First set the category!"); } - else if (!isEnterprise() && (getSeverity() == 'unspecified')) { + else if (isEnterprise && !isEnterprise() && (getSeverity() == 'unspecified')) { alert("This won't do! Specify some severity!"); } else { diff --git a/data/lib/util.js b/data/lib/util.js index abf8824..6ed131e 100644 --- a/data/lib/util.js +++ b/data/lib/util.js @@ -294,7 +294,7 @@ function removeCSVValue(str, value) { */ function filterByRegexp(list, chosingMark) { var chosenPair = []; - if (list.length > 0) { + if (list && list.length > 0) { chosenPair = list.filter(function (pair) { return new RegExp(pair.regexp, "i").test(chosingMark); }); |