aboutsummaryrefslogtreecommitdiffstats
path: root/data/lib/addAttachmentRow.js
diff options
context:
space:
mode:
authorMatěj Cepl <mcepl@redhat.com>2011-04-29 01:22:18 +0200
committerMatěj Cepl <mcepl@redhat.com>2011-04-29 01:32:27 +0200
commite3989a9404d19fb5164b39f7f6c78e64cc85b137 (patch)
treeb2ceedb4a43b2e85a4d083933a6ca5678b32236f /data/lib/addAttachmentRow.js
parentaf9a8239914fb783ddd41a9dc571bd5fb2126050 (diff)
downloadbugzilla-triage-e3989a9404d19fb5164b39f7f6c78e64cc85b137.tar.gz
All XML-RPC calls are rewritten as JSON-RPC ones.
* also MakeJSONRPCall is a functional call now * reorganization for dealing with the history.
Diffstat (limited to 'data/lib/addAttachmentRow.js')
-rw-r--r--data/lib/addAttachmentRow.js32
1 files changed, 26 insertions, 6 deletions
diff --git a/data/lib/addAttachmentRow.js b/data/lib/addAttachmentRow.js
index a2b67ee..3bee73a 100644
--- a/data/lib/addAttachmentRow.js
+++ b/data/lib/addAttachmentRow.js
@@ -2,6 +2,7 @@
// http://www.opensource.org/licenses/mit-license.php
"use strict";
+// FIXME resp is JSON, not XML anymore
function addAttachmentCallback(resp) {
var newAttachID = parseInt(
resp.params.param.value.array.data.value.int, 10);
@@ -13,6 +14,25 @@ function addAttachmentCallback(resp) {
*
* This has to stay in RHBugzillaPage because upstream doesn't have
* addAttachment XML-RPC call yet.
+ *
+ Params: $params = {
+ id => '<bug_id>', # ID of the bug report
+ comment => "<Attachment Comment>", # OPTIONAL Text string containing comment to add.
+ description => "<Attachment Description>", # REQUIRED Text Description of the attachment.
+ isprivate => <Private Attachment ON/OFF 1/0>, # OPTIONAL Whether the Attachment
+ will be private # Default: false
+ filename => "<Attachment Filename>", REQUIRED The name of the file to attach to the bug report.
+ obsoletes => [List of attach_id's to obsolete], OPTIONAL List if attachment ids that are
+ obsoleted by this new attachment.
+ ispatch => <Patch Attachment True/False 1/0>, OPTIONAL Whether the attachment is a Patch
+ or not, if not provided the it will be considered NON Patch attachment.
+ contenttype => "<Attachment Content Type>", OPTIONAL If the attachment is patch
+ REQUIRED If the attachment is not a patch
+ If the attachment is patch then contenttype will always be text/plain
+ data => "<Encoded String of the Attachment Data>", REQUIRED It is a base64
+ encoded string of the actual attachment data.
+ nomail => 0, OPTIONAL Flag that is either 1 or 0 if you want email
+ to be send ot not for this change }
*/
function addAttachment(data, callback, param) {
var params = [];
@@ -23,18 +43,18 @@ function addAttachment(data, callback, param) {
return null;
}
- params.push(getBugNo());
- params.push({
+ var params = {
+ id: getBugNo(),
description : titleParsedAttachment,
filename : "parsed-backtrace.txt",
contenttype : "text/plain",
data : window.btoa(data),
nomail : true
- });
+ };
- self.postMessage(new Message("MakeXMLRPCall", {
- url : constantData.XMLRPCData[window.location.hostname].url,
- login : getLogin(),
+ self.postMessage(new Message("MakeJSONRPCCall", {
+ url : constantData.XMLRPCData[window.location.hostname].url.
+ replace("xmlrpc.cgi","jsonrpc.cgi"),
method : "bugzilla.addAttachment",
params : params,
callRPC : "AddAttachmentCallback"