Make queryLocal and XML-RPC generally work again.

12 files changed, 140 insertions, 20 deletions

diff --git a/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/829f5222-d220-4406-90da-835b72b70a97/values b/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/829f5222-d220-4406-90da-835b72b70a97/values
new file mode 100644
index 0000000..8fe2990
--- /dev/null
+++ b/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/829f5222-d220-4406-90da-835b72b70a97/values
@@ -0,0 +1,21 @@
+creator: Matěj Cepl <mcepl@redhat.com>
+
+
+extra_strings:
+- BLOCKS:99abb100-a0e8-49b0-8799-a47e4d5fb0b3
+
+
+reporter: Matěj Cepl <mcepl@redhat.com>
+
+
+severity: minor
+
+
+status: open
+
+
+summary: make it work on BMO and BGO again
+
+
+time: Thu, 17 Feb 2011 17:09:22 +0000
+
diff --git a/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/88fa923c-59ee-47bf-b7c8-d1a7a7bdeb33/values b/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/88fa923c-59ee-47bf-b7c8-d1a7a7bdeb33/values
index 0dc8d4f..bd41f28 100644
--- a/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/88fa923c-59ee-47bf-b7c8-d1a7a7bdeb33/values
+++ b/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/88fa923c-59ee-47bf-b7c8-d1a7a7bdeb33/values
@@ -7,7 +7,7 @@ reporter: Matěj Cepl <mcepl@redhat.com>
 severity: minor
 
 
-status: open
+status: closed
 
 
 summary: Hide "Fill in" button when it is not meaningful
diff --git a/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/99abb100-a0e8-49b0-8799-a47e4d5fb0b3/values b/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/99abb100-a0e8-49b0-8799-a47e4d5fb0b3/values
index ab5e8e7..cc186bb 100644
--- a/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/99abb100-a0e8-49b0-8799-a47e4d5fb0b3/values
+++ b/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/99abb100-a0e8-49b0-8799-a47e4d5fb0b3/values
@@ -1,6 +1,10 @@
 creator: Matěj Cepl <mcepl@redhat.com>
 
 
+extra_strings:
+- BLOCKED-BY:829f5222-d220-4406-90da-835b72b70a97
+
+
 reporter: Matěj Cepl <mcepl@redhat.com>
 
 
diff --git a/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/9ba533b6-61b6-437a-b4b6-be12aae025e5/values b/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/9ba533b6-61b6-437a-b4b6-be12aae025e5/values
new file mode 100644
index 0000000..cbf5191
--- /dev/null
+++ b/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/9ba533b6-61b6-437a-b4b6-be12aae025e5/values
@@ -0,0 +1,17 @@
+creator: Matěj Cepl <mcepl@redhat.com>
+
+
+reporter: Matěj Cepl <mcepl@redhat.com>
+
+
+severity: minor
+
+
+status: fixed
+
+
+summary: queryLocal doesn't
+
+
+time: Thu, 17 Feb 2011 17:08:36 +0000
+
diff --git a/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/e16d92aa-df09-4851-b6a0-3ed0ea2ff0fa/comments/12d5c683-231b-4b4f-8f05-b6ae32a5b0a8/body b/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/e16d92aa-df09-4851-b6a0-3ed0ea2ff0fa/comments/12d5c683-231b-4b4f-8f05-b6ae32a5b0a8/body
new file mode 100644
index 0000000..32b4893
--- /dev/null
+++ b/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/e16d92aa-df09-4851-b6a0-3ed0ea2ff0fa/comments/12d5c683-231b-4b4f-8f05-b6ae32a5b0a8/body
@@ -0,0 +1,49 @@
+info: messageHandler: msg = ({cmd:"MakeXMLRPCall",
+data:{url:{url:"https://bugzilla.redhat.com/xmlrpc.cgi"},
+login:"mcepl@redhat.com", method:"bugzilla.updateAttachMimeType",
+params:[{attach_id:"479099", mime_type:"text/plain",
+nomail:true}], callRPC:"FixAttachmentMIMECallback"}})
+error: An exception occurred.
+Traceback (most recent call last):
+  File
+"resource://jid0-uxmbewgoltuuuqrhkhrr7hw3iqy-api-utils-lib/timer.js",
+line 64, in notifyOnTimeout
+    this._callback.apply(null, this._params);
+  File
+"resource://jid0-uxmbewgoltuuuqrhkhrr7hw3iqy-api-utils-lib/content/worker.js",
+line 64, in emitter
+    emit.apply(scope, params);
+  File
+"resource://jid0-uxmbewgoltuuuqrhkhrr7hw3iqy-api-utils-lib/events.js",
+line 129, in _emit
+    return this._emitOnObject.apply(this, args);
+  File
+"resource://jid0-uxmbewgoltuuuqrhkhrr7hw3iqy-api-utils-lib/events.js",
+line 159, in _emitOnObject
+    listener.apply(targetObj, params);
+  File
+"resource://jid0-uxmbewgoltuuuqrhkhrr7hw3iqy-bugzilla-triage-lib/main.js",
+line 134, in 
+    messageHandler(worker, msg);
+  File
+"resource://jid0-uxmbewgoltuuuqrhkhrr7hw3iqy-bugzilla-triage-lib/main.js",
+line 92, in messageHandler
+    msg.data.params, function(ret) {
+  File
+"resource://jid0-uxmbewgoltuuuqrhkhrr7hw3iqy-bugzilla-triage-lib/libbugzilla.js",
+line 260, in makeXMLRPCCall
+    var urlObj = urlMod.URL(url);
+  File
+"resource://jid0-uxmbewgoltuuuqrhkhrr7hw3iqy-api-utils-lib/api-utils.js",
+line 69, in PublicCtor
+    privateCtor.apply(obj, arguments);
+  File
+"resource://jid0-uxmbewgoltuuuqrhkhrr7hw3iqy-api-utils-lib/url.js",
+line 97, in URL
+    var uri = newURI(url, base);
+  File
+"resource://jid0-uxmbewgoltuuuqrhkhrr7hw3iqy-api-utils-lib/url.js",
+line 51, in newURI
+    throw new Error("malformed URI: " + uriStr);
+Error: malformed URI: [object Object]
+
diff --git a/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/e16d92aa-df09-4851-b6a0-3ed0ea2ff0fa/comments/12d5c683-231b-4b4f-8f05-b6ae32a5b0a8/values b/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/e16d92aa-df09-4851-b6a0-3ed0ea2ff0fa/comments/12d5c683-231b-4b4f-8f05-b6ae32a5b0a8/values
new file mode 100644
index 0000000..e239bfd
--- /dev/null
+++ b/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/e16d92aa-df09-4851-b6a0-3ed0ea2ff0fa/comments/12d5c683-231b-4b4f-8f05-b6ae32a5b0a8/values
@@ -0,0 +1,8 @@
+Author: Matěj Cepl <mcepl@redhat.com>
+
+
+Content-type: text/plain
+
+
+Date: Thu, 17 Feb 2011 15:14:51 +0000
+
diff --git a/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/e16d92aa-df09-4851-b6a0-3ed0ea2ff0fa/values b/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/e16d92aa-df09-4851-b6a0-3ed0ea2ff0fa/values
new file mode 100644
index 0000000..627b9d6
--- /dev/null
+++ b/.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/e16d92aa-df09-4851-b6a0-3ed0ea2ff0fa/values
@@ -0,0 +1,17 @@
+creator: Matěj Cepl <mcepl@redhat.com>
+
+
+reporter: Matěj Cepl <mcepl@redhat.com>
+
+
+severity: minor
+
+
+status: fixed
+
+
+summary: XMLRPC call doesn't
+
+
+time: Thu, 17 Feb 2011 15:14:19 +0000
+
diff --git a/.be/id-cache b/.be/id-cache
index 9f48012..cc11320 100644
--- a/.be/id-cache
+++ b/.be/id-cache
@@ -1,14 +1,18 @@
 5718cbae-15da-4921-8371-5be69197c4ed	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/5718cbae-15da-4921-8371-5be69197c4ed
+d4145155-0ef1-409e-9236-261eb08f75d5	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/d4145155-0ef1-409e-9236-261eb08f75d5
+a9d5d16d-1c7d-4918-8be2-bd499a799b54	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/989f85c8-3941-4a97-a447-bdbf0fbbd7f4/comments/a9d5d16d-1c7d-4918-8be2-bd499a799b54
 27c176c2-26be-4a51-bb71-2aff47c5484b	.be/27c176c2-26be-4a51-bb71-2aff47c5484b
 70b1e7f3-6446-45dc-91e5-e338d51770aa	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/99abb100-a0e8-49b0-8799-a47e4d5fb0b3/comments/70b1e7f3-6446-45dc-91e5-e338d51770aa
-a9d5d16d-1c7d-4918-8be2-bd499a799b54	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/989f85c8-3941-4a97-a447-bdbf0fbbd7f4/comments/a9d5d16d-1c7d-4918-8be2-bd499a799b54
+829f5222-d220-4406-90da-835b72b70a97	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/829f5222-d220-4406-90da-835b72b70a97
+12d5c683-231b-4b4f-8f05-b6ae32a5b0a8	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/e16d92aa-df09-4851-b6a0-3ed0ea2ff0fa/comments/12d5c683-231b-4b4f-8f05-b6ae32a5b0a8
+9ba533b6-61b6-437a-b4b6-be12aae025e5	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/9ba533b6-61b6-437a-b4b6-be12aae025e5
 ca8df3f8-7557-4730-bcca-3707776f5db4	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/ca8df3f8-7557-4730-bcca-3707776f5db4
 b9e11546-5ec7-4464-8070-35c5510c13ff	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/d4145155-0ef1-409e-9236-261eb08f75d5/comments/b9e11546-5ec7-4464-8070-35c5510c13ff
 29f5f313-559a-4fea-88fa-fc4a4fc94112	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/5fc172f0-231a-4d0e-9c6b-8d9f60abbfba/comments/29f5f313-559a-4fea-88fa-fc4a4fc94112
-d4145155-0ef1-409e-9236-261eb08f75d5	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/d4145155-0ef1-409e-9236-261eb08f75d5
+11c4a6bb-a7a5-4d18-bab5-14ab119bb3ef	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/ca8df3f8-7557-4730-bcca-3707776f5db4/comments/11c4a6bb-a7a5-4d18-bab5-14ab119bb3ef
 99abb100-a0e8-49b0-8799-a47e4d5fb0b3	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/99abb100-a0e8-49b0-8799-a47e4d5fb0b3
 5fc172f0-231a-4d0e-9c6b-8d9f60abbfba	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/5fc172f0-231a-4d0e-9c6b-8d9f60abbfba
 ecff7ddb-1d5f-406b-9b3b-18388d575604	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/5718cbae-15da-4921-8371-5be69197c4ed/comments/ecff7ddb-1d5f-406b-9b3b-18388d575604
 989f85c8-3941-4a97-a447-bdbf0fbbd7f4	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/989f85c8-3941-4a97-a447-bdbf0fbbd7f4
-11c4a6bb-a7a5-4d18-bab5-14ab119bb3ef	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/ca8df3f8-7557-4730-bcca-3707776f5db4/comments/11c4a6bb-a7a5-4d18-bab5-14ab119bb3ef
+e16d92aa-df09-4851-b6a0-3ed0ea2ff0fa	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/e16d92aa-df09-4851-b6a0-3ed0ea2ff0fa
 88fa923c-59ee-47bf-b7c8-d1a7a7bdeb33	.be/27c176c2-26be-4a51-bb71-2aff47c5484b/bugs/88fa923c-59ee-47bf-b7c8-d1a7a7bdeb33
diff --git a/data/bzpage.js b/data/bzpage.js
index 872f4f1..c1ff730 100644
--- a/data/bzpage.js
+++ b/data/bzpage.js
@@ -30,7 +30,7 @@ onMessage = function onMessage(msg) {
         document.location.reload(true);
         break;
     case "queryLocal":
-        queryInNewTab(msg.data.data, getComponent(), getProduct());
+        queryInNewTab(msg.data, getComponent(), getProduct());
         break;
     case "CreateButtons":
         constantData = msg.data.constData;
@@ -602,7 +602,7 @@ function addStuffToTextBox (id, stuff) {
  * @param stuff String/Array with keyword(s) to be removed
  */
 function removeStuffFromTextBox (id, stuff) {
-    var changedElement = this.getElementById(id);
+    var changedElement = document.getElementById(id);
     changedElement.value = removeCSVValue(changedElement.value,stuff);
 }
 
@@ -686,7 +686,7 @@ function getOwner () {
  * @return String with the maintainer's email address
  */
 function getDefaultBugzillaMaintainer (component) {
-    var address = filterByRegexp(this.defBugzillaMaintainerArr, component);
+    var address = filterByRegexp(constantData.defBugzillaMaintainerArr, component);
     return address;
 }
 
@@ -854,10 +854,10 @@ function queryInNewTab(text, component, product) {
         urlStr += "&product=" + product.trim();
     }
     if (component) {
-        if ("equivalentComponents" in this.constantData) {
-            var equivCompsArr = this.constantData["equivalentComponents"].
+        if ("equivalentComponents" in constantData) {
+            var equivCompsArr = constantData.equivalentComponents.
                 filter(function (REstr) {
-                    return new RegExp(REstr).test(this.getComponent());
+                    return new RegExp(REstr).test(getComponent());
             }, this);
             if (equivCompsArr.length > 0) {
                 component = equivCompsArr[0];
@@ -882,7 +882,7 @@ function queryInNewTab(text, component, product) {
                 + "&field1-0-2=status_whiteboard&type1-0-2=substring&value1-0-2="
                 + text;
         urlStr += searchText;
-        postMessage(new Message("OpenURLinPanel", urlStr));
+        postMessage(new Message("OpenURLinTab", urlStr));
     }
 }
 
diff --git a/data/rhbzpage.js b/data/rhbzpage.js
index ce0d3fd..15bbd0c 100644
--- a/data/rhbzpage.js
+++ b/data/rhbzpage.js
@@ -172,7 +172,7 @@ function addAttachment(data, callback, param) {
     });
 
     postMessage(new Message("MakeXMLRPCall", {
-        url: constantData.XMLRPCData[window.location.hostname],
+        url: constantData.XMLRPCData[window.location.hostname].url,
         login: getLogin(),
         method: "bugzilla.addAttachment",
         params: params,
@@ -658,6 +658,7 @@ function fillInChipMagic(XorgLogAttList, XorgLogAttListIndex) {
                         replace(/[\s"]+/g," ").trim();
                     // that.packages["rh-xorg"].chipMagic.chipMagic = interestingLine+"\t"+interestingArray[1]
                     //    .toUpperCase();
+                    console.log("interestingLineArr = " + interestingLineArr.toSource());
                     createNewButton("status_whiteboard", true, {
                         "name": "Fill In",
                         "chipMagic": true
@@ -781,7 +782,7 @@ function fixAttachById(id, type, email) {
     });
 
     postMessage(new Message("MakeXMLRPCall", {
-        url: constantData.XMLRPCData[window.location.hostname],
+        url: constantData.XMLRPCData[window.location.hostname].url,
         login: getLogin(),
         method: "bugzilla.updateAttachMimeType",
         params: params,
diff --git a/lib/libbugzilla.js b/lib/libbugzilla.js
index 2ec69a6..d30a025 100644
--- a/lib/libbugzilla.js
+++ b/lib/libbugzilla.js
@@ -87,7 +87,7 @@ function getPassword(login, domain) {
 
     // pass === null means no appropriatjslie password in the storage
     if (!preferences.get(prefName,false) && (pass === null)) {
-        passwordText = prompts.promptPassword(passPrompt);
+        var passwordText = prompts.promptPassword(passPrompt);
         if (passwordText && passwordText.length > 0) {
             passUtils.setLogin(login, passwordText, domain,
                 BTSPassRealm);
@@ -262,6 +262,8 @@ exports.makeXMLRPCCall = function makeXMLRPCCall(url, login, method, params, cal
     if (!passwObj.password) {
         return null; // TODO this should happen, only when user presses Escape in password prompt
     }
+    console.log("makeXMLRPCCall :\n\turl = " + url + "\n\tlogin = " + login + "\n\tmethod = " +
+        method + "\n\tparams = " + params.toSource() + "\n\tcallback = " + callback.toSource());
 
     var msg = new xrpc.XMLRPCMessage(method);
     params.forEach(function (par) {
@@ -275,7 +277,7 @@ exports.makeXMLRPCCall = function makeXMLRPCCall(url, login, method, params, cal
         onComplete: function(response) {
             if (response.status == 200) {
                 var resp = parseXMLfromString(response.text);
-                callback(resp);
+                callback(resp.toXMLString());
             }
         },
         content: msg.xml(),
diff --git a/lib/main.js b/lib/main.js
index cd8f259..a169fae 100644
--- a/lib/main.js
+++ b/lib/main.js
@@ -78,7 +78,7 @@ var messageHandler = exports.messageHandler = function messageHandler(worker, ms
         libbz.changeJSONURL();
         break;
     case "OpenURLinPanel":
-        libbz.openURLinPanel(msg.data);
+        libbz.openURLInNewPanel(msg.data);
         break;
     case "OpenURLinTab":
         libbz.openURLInNewTab(msg.data);
@@ -90,10 +90,7 @@ var messageHandler = exports.messageHandler = function messageHandler(worker, ms
         // url, login, method, params, callback
         libbz.makeXMLRPCCall(msg.data.url, msg.data.login, msg.data.method,
             msg.data.params, function(ret) {
-                worker.postMessage({
-                    payback: ret,
-                    cbRPC: msg.data.callRPC
-                });
+                worker.postMessage(new Message(msg.data.callRPC, ret));
         });
         break;
     case "GetURL":