aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatěj Cepl <mcepl@redhat.com>2010-09-30 11:58:56 +0200
committerMatěj Cepl <mcepl@redhat.com>2010-09-30 11:58:56 +0200
commit2c551111674af47960fb98e469b2d928e4a60628 (patch)
treee192aef1b3f1bfd718785354e58079c011198232
parent29699cd28c82b221a79feaa7dbb4a46beb51b5d8 (diff)
downloadbugzilla-triage-2c551111674af47960fb98e469b2d928e4a60628.tar.gz
A bit of cleanup ... removed one TODO
-rw-r--r--lib/rhbzpage.js14
1 files changed, 9 insertions, 5 deletions
diff --git a/lib/rhbzpage.js b/lib/rhbzpage.js
index 463a546..2ab161f 100644
--- a/lib/rhbzpage.js
+++ b/lib/rhbzpage.js
@@ -276,15 +276,19 @@ RHBugzillaPage.prototype.addAttachment = function addAttachment(data, callback,
*
*/
RHBugzillaPage.prototype.pasteBacktraceInComments = function() {
- // TODO This paragraph looks suspicous ... what is it?
- // Does it belong to this function?
var that = this;
+
+ /*
+ Let's comment it out, and we'll see if anything breaks.
+ TODO This paragraph looks suspicous ... what is it?
+ Does it belong to this function?
var notedLabel = this.doc.querySelector("label[for='newcc']");
while (notedLabel.firstChild) {
var node = notedLabel.removeChild(notedLabel.firstChild);
notedLabel.parentNode.insertBefore(node, notedLabel);
}
notedLabel.parentNode.removeChild(notedLabel);
+ */
var abrtQueryURL = "https://bugzilla.redhat.com/buglist.cgi?" +
"cmdtype=dorem&remaction=run&namedcmd=all%20NEW%20abrt%20crashes&"+
@@ -440,10 +444,10 @@ RHBugzillaPage.prototype.addCheckShowLink = function addCheckShowLink(oldAtt, sn
/**
* Make it sailent that the some attachments with bad MIME type are present
*
- * @param none // TODO we should make it more functional
+ * @param atts Array of attachments subarrays
* @return none
*/
-RHBugzillaPage.prototype.markBadAttachments = function() {
+RHBugzillaPage.prototype.markBadAttachments = function(atts) {
var that = this;
var badMIMEArray = [ "application/octet-stream", "text/x-log", "undefined" ];
if (!this.password) {
@@ -451,7 +455,7 @@ RHBugzillaPage.prototype.markBadAttachments = function() {
// should be switched off.
}
- var badAttachments = this.attachments.filter(function(att, idx, arr) {
+ var badAttachments = atts.filter(function(att, idx, arr) {
return (util.isInList(att[2], badMIMEArray));
});