aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatěj Cepl <mcepl@redhat.com>2009-12-08 02:59:02 +0100
committerMatěj Cepl <mcepl@redhat.com>2009-12-08 02:59:02 +0100
commit80d137816a7e404b6d4a4c76fca7e1de2bb2099a (patch)
treef739ab14cb6d9ed04351517eb0a3b77e8ea3ae48
parent8d152c127ba7bddbca09b9716bd4c14390fda7fd (diff)
downloadbugzilla-triage-80d137816a7e404b6d4a4c76fca7e1de2bb2099a.tar.gz
Fix couple of small bugs
-rw-r--r--bugzillaBugTriage.js18
1 files changed, 10 insertions, 8 deletions
diff --git a/bugzillaBugTriage.js b/bugzillaBugTriage.js
index d3dc7dd..e524fe7 100644
--- a/bugzillaBugTriage.js
+++ b/bugzillaBugTriage.js
@@ -756,15 +756,16 @@ bzPage.prototype.queryInNewTab = function(text,component,product) {
}
var url = "https://bugzilla.redhat.com/buglist.cgi?query_format=advanced";
if (product) {
- url += "&product="+product;
+ url += "&product="+$.trim(product);
}
if (component) {
- url += "&component="+component;
+ url += "&field0-0-0=component&type0-0-0=substring&value0-0-0="+$.trim(component);
}
if (text) {
- url += "&field0-0-0=longdesc&type0-0-0=substring&value0-0-0="+text+
- "&field0-0-1=attach_data.thedata&type0-0-1=substring&value0-0-1="+text+
- "&field0-0-2=status_whiteboard&type0-0-2=substring&value0-0-2="+text;
+ text = $.trim(text);
+ url += "&field1-0-0=longdesc&type1-0-0=substring&value1-0-0="+text+
+ "&field1-0-1=attach_data.thedata&type1-0-1=substring&value1-0-1="+text+
+ "&field1-0-2=status_whiteboard&type1-0-2=substring&value1-0-2="+text;
}
jetpack.tabs.open(url);
};
@@ -975,6 +976,7 @@ bzPage.prototype.callBack = function(data,textStatus) {
* @param password string with password
* @param attachID Number with the attachment ID#
* @param mimeType string with MIME type, optional and defaults to text/plain
+ * @param email Boolean whether we should send email or not
* @return string with the XML-RPC message
updateAttachMimeType($data_ref, $username, $password)
@@ -1014,7 +1016,7 @@ bzPage.prototype.createXMLRPCMessage = function(login,password,attachId,mimeType
</member>
<member>
<name>nomail</name>
- <value><string>{emailStr}</string></value>
+ <value><boolean>{emailStr}</boolean></value>
</member>
</struct></value>
</param>
@@ -1233,7 +1235,7 @@ bzPage.prototype.generalPurposeCureForAllDisease = function
if (!isInList(this.maintCCAddr, this.CCList)) {
$("#newcc",this.doc).text(this.maintCCAddr);
}
- if ((!this.isRHELBug()) && (verNo < TriagedDistro)) {
+ if ((!this.isRHEL()) && (verNo < TriagedDistro)) {
this.selectOption("bug_status", nextState);
}
this.setKeyword("Triaged");
@@ -1386,7 +1388,7 @@ function bzPage(doc) {
var titleElement = $(".bz_alias_short_desc_container:first",this.doc).
css("background-color","olive").
append($(this.createFixAllButton(badAttachments)));
- badAttachments.forEach(function (x) {
+ badAttachments.forEach(function (x,i,a) {
that.addTextLink(x);
});
}