.attr("value") is clearly work of the Evil one.

Get rid of it and replace with .val()

1 files changed, 9 insertions, 12 deletions

diff --git a/bugzillaBugTriage.js b/bugzillaBugTriage.js
index 5a7ca59..9dba30f 100644
--- a/bugzillaBugTriage.js
+++ b/bugzillaBugTriage.js
@@ -414,12 +414,12 @@ bzPage.prototype.fillInWhiteBoard = function (iLine, driverStr) {
         }
     }
     var whiteboardInput = $("#status_whiteboard",this.doc);
-    var oldWhiteboard = whiteboardInput.attr("value");
+    var oldWhiteboard = whiteboardInput.val();
     var attachedText = $.trim("card_"+outStr);
     if (oldWhiteboard) {
         attachedText += ", " + oldWhiteboard;
     }
-    whiteboardInput.attr("value",attachedText);
+    whiteboardInput.val(attachedText);
     $("#chipmagic", this.doc).css("display","none");
 };
 
@@ -662,7 +662,7 @@ bzPage.prototype.changeOwner = function(newAssignee) {
     }
     this.clickMouse($("#bz_assignee_edit_action",this.doc));
     $("#set_default_assignee",this.doc).removeAttr("checked");
-    $("#assigned_to", this.doc).attr("value",newAssignee);
+    $("#assigned_to", this.doc).val(newAssignee);
     $("#setdefaultassigneebutton", this.doc).css("display","none");
 }
 
@@ -688,10 +688,10 @@ bzPage.prototype.addTextToComment = function(string2BAdded) {
 
     // don't remove the current content of the comment box,
     // just behave accordingly
-    if (commentTextarea.attr("value").length > 0) {
-        commentTextarea.attr("value",commentTextarea.attr("value") + "\n\n");
+    if (commentTextarea.val().length > 0) {
+        commentTextarea.val(commentTextarea.val() + "\n\n");
     }
-    commentTextarea.attr("value",commentTextarea.attr("value") + string2BAdded);
+    commentTextarea.val(commentTextarea.val() + string2BAdded);
 }
 
 /**
@@ -1078,7 +1078,7 @@ bzPage.prototype.buildButtons = function (above,below) {
         }
     if ((chipIDsGroupings.length >0) && this.maintCCAddr == "xgl-maint@redhat.com") {
         // Add find chip magic button
-        var whiteboard_string = $("#status_whiteboard", this.doc).attr("value");
+        var whiteboard_string = $("#status_whiteboard", this.doc).val();
         if (whiteboard_string.indexOf("card_") == -1) {
             this.fillInChipMagic();
         }
@@ -1099,7 +1099,6 @@ function bzPage(doc) {
     this.originalButton = $("#commit", this.doc);
     var loginArr = $("#header ul:first li:last", this.doc).text().split("\n");
     this.login = $.trim(loginArr[loginArr.length-1]);
-    console.log("login = " + this.login);
     this.password = "";
     if (myConfig.BZpassword) {
         this.password = myConfig.BZpassword;
@@ -1116,10 +1115,8 @@ function bzPage(doc) {
     this.product   = $("#product option:selected:first", this.doc).text();
     this.component = $("#component option:selected:first", this.doc).text();
     this.version   = this.getVersion();
-    console.log("version = " + this.version);
-    this.its       = $.trim($("#cf_issuetracker", this.doc).attr("value"));
-    console.log("its = " + this.its);
-    this.CCList    = $.makeArray($("#cc", this.doc).attr("value"));
+    this.its       = $.trim($("#cf_issuetracker", this.doc).val());
+    this.CCList    = $.makeArray($("#cc", this.doc).val());
     this.owner     = $("#bz_assignee_edit_container .fn:first", this.doc).text();
     this.defaultAssignee = filterByRegexp(defAssigneeList, this.component).toLowerCase();
     this.maintCCAddr = filterByRegexp(AddrArray,this.component).toLowerCase();