aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatěj Cepl <mcepl@redhat.com>2011-03-07 17:53:22 +0100
committerMatěj Cepl <mcepl@redhat.com>2011-03-07 17:53:22 +0100
commitc602976d443e720f0a0797c11b7966c32a1159b8 (patch)
treee804f1b1b9bd113a809db16972b2e4f9187b2df7
parent46cf99a823462c3e3b9e88805deca3e31a68003f (diff)
parent0c54ada8588dc27ab69ccc3b385a8fc6a8c89251 (diff)
downloadbugzilla-triage-c602976d443e720f0a0797c11b7966c32a1159b8.tar.gz
Merge branch 'anyAllJSON' into next
Conflicts: lib/libbugzilla.js
-rw-r--r--jsons/Config_data.json2
-rw-r--r--lib/libbugzilla.js13
2 files changed, 7 insertions, 8 deletions
diff --git a/jsons/Config_data.json b/jsons/Config_data.json
index 01775f1..8db7b27 100644
--- a/jsons/Config_data.json
+++ b/jsons/Config_data.json
@@ -116,7 +116,7 @@
"https://bugzilla.gnome.org/show_bug.cgi.*"
],
"enabledPackages":{
- "bugzilla.redhat.com":"any"
+ "bugzilla.redhat.com":"all"
},
"killNodes":{
"bugzilla.gnome.org":[
diff --git a/lib/libbugzilla.js b/lib/libbugzilla.js
index 9300c49..6d556a4 100644
--- a/lib/libbugzilla.js
+++ b/lib/libbugzilla.js
@@ -61,7 +61,7 @@ function getRealBugNoSlow(bugNo, location, callback) {
onComplete: function(response) {
if (response.status === 200) {
var xmlRepr = parseXMLfromString(response.text);
- // TODO this is probably wrong, both XPath and .text attribute
+ // TODO this probably wrong, both XPath and .text attribute
var bugID = parseInt(xmlRepr.bug.bug_id.text, 10);
if (isNaN(bugID)) {
throw new Error("Cannot get bug no. even from XML representation!");
@@ -85,7 +85,7 @@ function getPassword(login, domain) {
withoutPass: false // whether user doesn't want to use password at all
};
- // pass === null means no appropriatjslie password in the storage
+ // pass === null means no appropriate password in the storage
if (!preferences.get(prefName,false) && (pass === null)) {
var passwordText = prompts.promptPassword(passPrompt);
if (passwordText && passwordText.length > 0) {
@@ -148,11 +148,10 @@ exports.getInstalledPackages = function getInstalledPackages(locationLoginObj, c
}
}
- if ((enabledPackages.length === 1) && (enabledPackages[0] === "all")) {
- enabledPackages = [];
- for (var key in config.gJSONData.commentPackages) {
- enabledPackages.push(key);
- }
+ var allIdx = null;
+ if ((allIdx = enabledPackages.indexOf("all")) != -1) {
+ enabledPackages = enabledPackages.splice(allIdx,
+ config.gJSONData.commentPackages.keys());
}
// TODO To be decided, whether we cannot just eliminate packages in