aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatěj Cepl <mcepl@redhat.com>2011-05-31 23:37:20 +0200
committerMatěj Cepl <mcepl@redhat.com>2011-06-05 14:53:48 +0200
commite6fc443ce7008856fc4285ae9020deeb442e04a6 (patch)
treeaad2597432f5e77ca4450a137759f1e06b5dac7c
parentdbde936df9b45730586677f1d178044668d86229 (diff)
downloadbugzilla-triage-e6fc443ce7008856fc4285ae9020deeb442e04a6.tar.gz
Fix broken subsequent calls to message handlers.
Fixes #104 But really, this is whole broken, and we need to eliminate direct calls and use event handlers internally.
-rw-r--r--data/mozlib/mozpage.js4
-rw-r--r--data/rhlib/rhbzpage.js4
-rw-r--r--data/tweaks/bug-page-mod.js2
-rw-r--r--package.json2
-rw-r--r--update.rdf15
5 files changed, 21 insertions, 6 deletions
diff --git a/data/mozlib/mozpage.js b/data/mozlib/mozpage.js
index 86c1559..5185cd7 100644
--- a/data/mozlib/mozpage.js
+++ b/data/mozlib/mozpage.js
@@ -58,10 +58,10 @@ var mozFlags = (function() {
})();
// Currently empty message handler
-function MozOnMessageHandler(msg, nextHandler) {
+function MozOnMessageHandler(msg, nextHandlerList) {
switch (msg.cmd) {
default:
- if (nextHandler) {
+ if (nextHandlerList) {
var nextHandler = nextHandlerList.splice(0, 1);
if (nextHandler[0]) {
nextHandler[0](msg, nextHandlerList);
diff --git a/data/rhlib/rhbzpage.js b/data/rhlib/rhbzpage.js
index a130306..c3c36de 100644
--- a/data/rhlib/rhbzpage.js
+++ b/data/rhlib/rhbzpage.js
@@ -57,7 +57,7 @@ var ProfessionalProducts = [
var btSnippet = null;
-function RHOnMessageHandler(msg, nextHandler) {
+function RHOnMessageHandler(msg, nextHandlerList) {
switch (msg.cmd) {
case "Error":
alert("Error " + msg.data);
@@ -78,7 +78,7 @@ function RHOnMessageHandler(msg, nextHandler) {
queryUpstreamCallback(msg.data, constantData.queryUpstreamBug);
break;
default:
- if (nextHandler) {
+ if (nextHandlerList) {
var nextHandler = nextHandlerList.splice(0, 1);
if (nextHandler[0]) {
nextHandler[0](msg, nextHandlerList);
diff --git a/data/tweaks/bug-page-mod.js b/data/tweaks/bug-page-mod.js
index 9be8551..f30e9e3 100644
--- a/data/tweaks/bug-page-mod.js
+++ b/data/tweaks/bug-page-mod.js
@@ -41,7 +41,7 @@ function TweakOnMessageHandler(msg, nextHandlerList) {
processHistory(msg.data);
break;
default:
- if (nextHandler) {
+ if (nextHandlerList) {
var nextHandler = nextHandlerList.splice(0, 1);
if (nextHandler[0]) {
nextHandler[0](msg, nextHandlerList);
diff --git a/package.json b/package.json
index 5e6d398..4f51983 100644
--- a/package.json
+++ b/package.json
@@ -7,7 +7,7 @@
"description": "Additional buttons and other function helping in the triage on bugzilla",
"author": "Matej Cepl (http://matej.ceplovi.cz)",
"license": "MIT/X11 (http://opensource.org/licenses/mit-license.php) and MPL",
- "version": "1.2",
+ "version": "1.3",
"contributors": [
"Ehsan Akhgari (http://ehsanakhgari.org/) <ehsan@mozilla.com>",
"Johnathan Nightingale (http://johnath.com) <johnath@mozilla.com>",
diff --git a/update.rdf b/update.rdf
index 7b1f4ce..8402b74 100644
--- a/update.rdf
+++ b/update.rdf
@@ -532,6 +532,21 @@ xmlns:em="http://www.mozilla.org/2004/em-rdf#">
</em:targetApplication>
</Description>
</li>
+ <li>
+ <Description>
+ <em:version>1.3</em:version>
+ <em:targetApplication>
+ <Description>
+ <em:id>
+ {ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
+ <em:minVersion>4.0b7</em:minVersion>
+ <em:maxVersion>7.0a1</em:maxVersion>
+ <em:updateLink>
+ https://fedorahosted.org/released/bugzilla-triage-scripts/bugzilla-triage-1.3.xpi</em:updateLink>
+ </Description>
+ </em:targetApplication>
+ </Description>
+ </li>
</Seq>
</em:updates>
</Description>