From 5dec1f09b1d4a642aff1f711c44eb12e61b6129c Mon Sep 17 00:00:00 2001 From: Robin Jarry Date: Thu, 21 Jul 2022 11:47:30 +0200 Subject: imap: fix error when server returns a message without body section When opening unread emails from certain people (I won't name any names, sorry), an annoying error message is displayed on the status line: could not get section &imap.BodySectionName{BodyPartName: imap.BodyPartName{Specifier:"", Path:[]int(nil), Fields:[]string(nil), NotFields:false}, Peek:false, Partial:[]int(nil), value} This does not occur for already read messages. This issue is similar to the one that was fixed in commit 8ed95b0d2ad2 ("imap: avoid crash when replying to unread message"). This happens because the flags are updated in the callback that receives the message itself. It causes the flag update to arrive in the same channel/request. Ignore the messages that have an empty body (i.e. only containing flag updates). This is inherently racy but there seems no way to get rid of these extra messages. Signed-off-by: Robin Jarry Acked-by: Koni Marti --- worker/imap/fetch.go | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'worker/imap') diff --git a/worker/imap/fetch.go b/worker/imap/fetch.go index 7d7b72fe..cf27e382 100644 --- a/worker/imap/fetch.go +++ b/worker/imap/fetch.go @@ -158,6 +158,10 @@ func (imapw *IMAPWorker) handleFetchFullMessages( } imapw.handleFetchMessages(msg, msg.Uids, items, func(_msg *imap.Message) error { + if len(_msg.Body) == 0 { + // ignore duplicate messages with only flag updates + return nil + } r := _msg.GetBody(section) if r == nil { return fmt.Errorf("could not get section %#v", section) -- cgit