From 606f8f0c701d349c8c1ff061587560cb46c0ba85 Mon Sep 17 00:00:00 2001 From: Robin Jarry Date: Thu, 24 Aug 2023 11:33:21 +0200 Subject: colorize: only emit osc8 if [general].enable-osc8=true Some old versions of less do not handle OSC 8 escape sequences. Even if aerc's embedded terminal is configured to handle them, less corrupts them making the output unreadable. 8;id=colorize-1;https://foobar.com/stuff/https://foobar.com/stuff/ When [general].enable-osc8 is set to false (its default value) do not attempt to generate OSC 8 sequences with the built-in colorize filter. These sequences would be stripped out anyway. Reported-by: Omar Polo Signed-off-by: Robin Jarry Acked-by: Kirill Chibisov --- widgets/msgviewer.go | 3 +++ 1 file changed, 3 insertions(+) (limited to 'widgets') diff --git a/widgets/msgviewer.go b/widgets/msgviewer.go index d1bee8c6..0908417d 100644 --- a/widgets/msgviewer.go +++ b/widgets/msgviewer.go @@ -620,6 +620,9 @@ func NewPartViewer( format.FormatAddresses(info.Envelope.From))) filter.Env = append(filter.Env, fmt.Sprintf("AERC_STYLESET=%s", acct.UiConfig().StyleSetPath())) + if config.General.EnableOSC8 { + filter.Env = append(filter.Env, "AERC_OSC8_URLS=1") + } log.Debugf("<%s> part=%v %s: %v | %v", info.Envelope.MessageId, curindex, mime, filter, pager) if pagerin, err = pager.StdinPipe(); err != nil { -- cgit