From ae83373fa63883f03bd5580ad3937d1e5fa428ed Mon Sep 17 00:00:00 2001 From: Moritz Poldrack Date: Tue, 22 Mar 2022 09:52:27 +0100 Subject: logging: added a log on panic Since panics still regularly "destroy" the terminal, it is hard to get a stack trace for panics you do not anticipate. This commit adds a panic handler that automatically creates a logfile inside the current working directory. It has to be added to every goroutine that is started and will repair the terminal on a panic. Signed-off-by: Moritz Poldrack Acked-by: Robin Jarry --- widgets/msgviewer.go | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'widgets/msgviewer.go') diff --git a/widgets/msgviewer.go b/widgets/msgviewer.go index 9b40dede..91baf025 100644 --- a/widgets/msgviewer.go +++ b/widgets/msgviewer.go @@ -19,6 +19,7 @@ import ( "git.sr.ht/~rjarry/aerc/lib" "git.sr.ht/~rjarry/aerc/lib/format" "git.sr.ht/~rjarry/aerc/lib/ui" + "git.sr.ht/~rjarry/aerc/logging" "git.sr.ht/~rjarry/aerc/models" ) @@ -600,6 +601,8 @@ func (pv *PartViewer) attemptCopy() { pv.copyFilterOutToPager() //delayed until we write to the sink } go func() { + defer logging.PanicHandler() + pv.writeMailHeaders() if strings.EqualFold(pv.part.MIMEType, "text") { // if the content is plain we can strip ansi control chars @@ -645,6 +648,8 @@ func (pv *PartViewer) copyFilterOutToPager() { pv.filter.Start() ch := make(chan interface{}) go func() { + defer logging.PanicHandler() + _, err := io.Copy(pv.pagerin, stdout) if err != nil { pv.err = err @@ -654,6 +659,8 @@ func (pv *PartViewer) copyFilterOutToPager() { ch <- nil }() go func() { + defer logging.PanicHandler() + _, err := io.Copy(pv.pagerin, stderr) if err != nil { pv.err = err @@ -663,6 +670,8 @@ func (pv *PartViewer) copyFilterOutToPager() { ch <- nil }() go func() { + defer logging.PanicHandler() + <-ch <-ch pv.filter.Wait() -- cgit