From 8c2a9cf6b90d5fe18fa7e5e110f6460e967ee036 Mon Sep 17 00:00:00 2001 From: Tim Culverhouse Date: Tue, 25 Apr 2023 07:57:13 -0500 Subject: term: fix handling of failed command A panic occurs when a terminal is launched with a command that fails: :term blabla The underlying terminal does not need to be closed if the command failed to start: all resources are cleaned up upon failure to start already. Don't attempt to close terminal if the command didn't start. With the above fix in place, the tab will linger around until a redraw occurs, as there is nothing queuing a redraw on this behavior. Add a QueueRedraw in the tabs.Remove method to clean up the tabbar. The issue in tcell-term that causes this panic has been address there as well, released as 0.7.1. Update aerc's version. Reported-by: Koni Marti Signed-off-by: Tim Culverhouse Tested-by: Koni Marti Acked-by: Robin Jarry --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'go.mod') diff --git a/go.mod b/go.mod index 28273a95..129ecc97 100644 --- a/go.mod +++ b/go.mod @@ -3,7 +3,7 @@ module git.sr.ht/~rjarry/aerc go 1.18 require ( - git.sr.ht/~rockorager/tcell-term v0.7.0 + git.sr.ht/~rockorager/tcell-term v0.7.1 git.sr.ht/~sircmpwn/getopt v1.0.0 github.com/ProtonMail/go-crypto v0.0.0-20230417170513-8ee5748c52b5 github.com/arran4/golang-ical v0.0.0-20230318005454-19abf92700cc -- cgit