From bc176bd61ba726351a489cabf4da16a47dc5ec3b Mon Sep 17 00:00:00 2001 From: Robin Jarry Date: Tue, 10 Oct 2023 00:08:31 +0200 Subject: app: export global functions The single Aerc object is passed around in almost all command functions. This hinders readability. Store the single Aerc instance as a global variable. Export public functions from the app package to access methods of that object. Remove all explicit references to *app.Aerc and replace them with calls to these functions. For references to private/unexported fields and functions from within the app package, directly access the global aerc object. Signed-off-by: Robin Jarry Acked-by: Moritz Poldrack --- commands/pin-tab.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'commands/pin-tab.go') diff --git a/commands/pin-tab.go b/commands/pin-tab.go index e2e897ed..7a3258d4 100644 --- a/commands/pin-tab.go +++ b/commands/pin-tab.go @@ -16,20 +16,20 @@ func (PinTab) Aliases() []string { return []string{"pin-tab", "unpin-tab"} } -func (PinTab) Complete(aerc *app.Aerc, args []string) []string { +func (PinTab) Complete(args []string) []string { return nil } -func (PinTab) Execute(aerc *app.Aerc, args []string) error { +func (PinTab) Execute(args []string) error { if len(args) != 1 { return fmt.Errorf("Usage: %s", args[0]) } switch args[0] { case "pin-tab": - aerc.PinTab() + app.PinTab() case "unpin-tab": - aerc.UnpinTab() + app.UnpinTab() } return nil -- cgit