From c26d08103b327bd3f2470e542aa55ab354483347 Mon Sep 17 00:00:00 2001 From: Robin Jarry Date: Fri, 25 Feb 2022 00:21:06 +0100 Subject: aerc: always check SelectedAccount return value aerc.SelectedAccount() is used in lots of places. Most of them without checking the return value. In some cases, the currently selected tab is not related to any account (widget.Terminal for example). This can lead to unexpected crashes when accessing account specific configuration. When possible, return an error when no account is currently selected. If no error can be returned, fallback to non-account specific configuration. Signed-off-by: Robin Jarry Reviewed-by: Koni Marti --- commands/msgview/next.go | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'commands/msgview/next.go') diff --git a/commands/msgview/next.go b/commands/msgview/next.go index 4291a6a5..742bc665 100644 --- a/commands/msgview/next.go +++ b/commands/msgview/next.go @@ -1,6 +1,8 @@ package msgview import ( + "errors" + "git.sr.ht/~rjarry/aerc/commands/account" "git.sr.ht/~rjarry/aerc/lib" "git.sr.ht/~rjarry/aerc/widgets" @@ -27,6 +29,9 @@ func (NextPrevMsg) Execute(aerc *widgets.Aerc, args []string) error { } mv, _ := aerc.SelectedTab().(*widgets.MessageViewer) acct := mv.SelectedAccount() + if acct == nil { + return errors.New("No account selected") + } store := mv.Store() err = account.ExecuteNextPrevMessage(args, acct, pct, n) if err != nil { -- cgit