From bc176bd61ba726351a489cabf4da16a47dc5ec3b Mon Sep 17 00:00:00 2001 From: Robin Jarry Date: Tue, 10 Oct 2023 00:08:31 +0200 Subject: app: export global functions The single Aerc object is passed around in almost all command functions. This hinders readability. Store the single Aerc instance as a global variable. Export public functions from the app package to access methods of that object. Remove all explicit references to *app.Aerc and replace them with calls to these functions. For references to private/unexported fields and functions from within the app package, directly access the global aerc object. Signed-off-by: Robin Jarry Acked-by: Moritz Poldrack --- commands/msgview/next-part.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'commands/msgview/next-part.go') diff --git a/commands/msgview/next-part.go b/commands/msgview/next-part.go index 6f314991..951842d7 100644 --- a/commands/msgview/next-part.go +++ b/commands/msgview/next-part.go @@ -17,11 +17,11 @@ func (NextPrevPart) Aliases() []string { return []string{"next-part", "prev-part"} } -func (NextPrevPart) Complete(aerc *app.Aerc, args []string) []string { +func (NextPrevPart) Complete(args []string) []string { return nil } -func (NextPrevPart) Execute(aerc *app.Aerc, args []string) error { +func (NextPrevPart) Execute(args []string) error { if len(args) > 2 { return nextPrevPartUsage(args[0]) } @@ -35,7 +35,7 @@ func (NextPrevPart) Execute(aerc *app.Aerc, args []string) error { return nextPrevPartUsage(args[0]) } } - mv, _ := aerc.SelectedTabContent().(*app.MessageViewer) + mv, _ := app.SelectedTabContent().(*app.MessageViewer) for ; n > 0; n-- { if args[0] == "prev-part" { mv.PreviousPart() -- cgit