From bc176bd61ba726351a489cabf4da16a47dc5ec3b Mon Sep 17 00:00:00 2001 From: Robin Jarry Date: Tue, 10 Oct 2023 00:08:31 +0200 Subject: app: export global functions The single Aerc object is passed around in almost all command functions. This hinders readability. Store the single Aerc instance as a global variable. Export public functions from the app package to access methods of that object. Remove all explicit references to *app.Aerc and replace them with calls to these functions. For references to private/unexported fields and functions from within the app package, directly access the global aerc object. Signed-off-by: Robin Jarry Acked-by: Moritz Poldrack --- commands/move-tab.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'commands/move-tab.go') diff --git a/commands/move-tab.go b/commands/move-tab.go index d85f3b2f..1aa20880 100644 --- a/commands/move-tab.go +++ b/commands/move-tab.go @@ -18,11 +18,11 @@ func (MoveTab) Aliases() []string { return []string{"move-tab"} } -func (MoveTab) Complete(aerc *app.Aerc, args []string) []string { +func (MoveTab) Complete(args []string) []string { return nil } -func (MoveTab) Execute(aerc *app.Aerc, args []string) error { +func (MoveTab) Execute(args []string) error { if len(args) == 1 { return fmt.Errorf("Usage: %s [+|-]", args[0]) } @@ -38,7 +38,7 @@ func (MoveTab) Execute(aerc *app.Aerc, args []string) error { if strings.HasPrefix(joinedArgs, "+") || strings.HasPrefix(joinedArgs, "-") { relative = true } - aerc.MoveTab(n, relative) + app.MoveTab(n, relative) return nil } -- cgit