From ae83373fa63883f03bd5580ad3937d1e5fa428ed Mon Sep 17 00:00:00 2001 From: Moritz Poldrack Date: Tue, 22 Mar 2022 09:52:27 +0100 Subject: logging: added a log on panic Since panics still regularly "destroy" the terminal, it is hard to get a stack trace for panics you do not anticipate. This commit adds a panic handler that automatically creates a logfile inside the current working directory. It has to be added to every goroutine that is started and will repair the terminal on a panic. Signed-off-by: Moritz Poldrack Acked-by: Robin Jarry --- commands/compose/send.go | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'commands/compose/send.go') diff --git a/commands/compose/send.go b/commands/compose/send.go index dbdb94f9..574e8727 100644 --- a/commands/compose/send.go +++ b/commands/compose/send.go @@ -16,6 +16,7 @@ import ( "github.com/pkg/errors" "git.sr.ht/~rjarry/aerc/lib" + "git.sr.ht/~rjarry/aerc/logging" "git.sr.ht/~rjarry/aerc/models" "git.sr.ht/~rjarry/aerc/widgets" "git.sr.ht/~rjarry/aerc/worker/types" @@ -100,6 +101,8 @@ func (Send) Execute(aerc *widgets.Aerc, args []string) error { failCh := make(chan error) //writer go func() { + defer logging.PanicHandler() + var sender io.WriteCloser switch ctx.scheme { case "smtp": @@ -131,6 +134,8 @@ func (Send) Execute(aerc *widgets.Aerc, args []string) error { //cleanup + copy to sent go func() { + defer logging.PanicHandler() + err = <-failCh if err != nil { aerc.PushError(strings.ReplaceAll(err.Error(), "\n", " ")) -- cgit