From bc176bd61ba726351a489cabf4da16a47dc5ec3b Mon Sep 17 00:00:00 2001 From: Robin Jarry Date: Tue, 10 Oct 2023 00:08:31 +0200 Subject: app: export global functions The single Aerc object is passed around in almost all command functions. This hinders readability. Store the single Aerc instance as a global variable. Export public functions from the app package to access methods of that object. Remove all explicit references to *app.Aerc and replace them with calls to these functions. For references to private/unexported fields and functions from within the app package, directly access the global aerc object. Signed-off-by: Robin Jarry Acked-by: Moritz Poldrack --- commands/compose/abort.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'commands/compose/abort.go') diff --git a/commands/compose/abort.go b/commands/compose/abort.go index d6ceae6d..a11c06c5 100644 --- a/commands/compose/abort.go +++ b/commands/compose/abort.go @@ -16,17 +16,17 @@ func (Abort) Aliases() []string { return []string{"abort"} } -func (Abort) Complete(aerc *app.Aerc, args []string) []string { +func (Abort) Complete(args []string) []string { return nil } -func (Abort) Execute(aerc *app.Aerc, args []string) error { +func (Abort) Execute(args []string) error { if len(args) != 1 { return errors.New("Usage: abort") } - composer, _ := aerc.SelectedTabContent().(*app.Composer) + composer, _ := app.SelectedTabContent().(*app.Composer) - aerc.RemoveTab(composer, true) + app.RemoveTab(composer, true) return nil } -- cgit