From ae83373fa63883f03bd5580ad3937d1e5fa428ed Mon Sep 17 00:00:00 2001 From: Moritz Poldrack Date: Tue, 22 Mar 2022 09:52:27 +0100 Subject: logging: added a log on panic Since panics still regularly "destroy" the terminal, it is hard to get a stack trace for panics you do not anticipate. This commit adds a panic handler that automatically creates a logfile inside the current working directory. It has to be added to every goroutine that is started and will repair the terminal on a panic. Signed-off-by: Moritz Poldrack Acked-by: Robin Jarry --- commands/account/compose.go | 7 ++++++- commands/account/recover.go | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) (limited to 'commands/account') diff --git a/commands/account/compose.go b/commands/account/compose.go index 1a62d0a3..4884b113 100644 --- a/commands/account/compose.go +++ b/commands/account/compose.go @@ -5,6 +5,7 @@ import ( "regexp" "strings" + "git.sr.ht/~rjarry/aerc/logging" "git.sr.ht/~rjarry/aerc/models" "git.sr.ht/~rjarry/aerc/widgets" "git.sr.ht/~sircmpwn/getopt" @@ -52,7 +53,11 @@ func (Compose) Execute(aerc *widgets.Aerc, args []string) error { } tab.Content.Invalidate() }) - go composer.AppendContents(strings.NewReader(body)) + go func() { + defer logging.PanicHandler() + + composer.AppendContents(strings.NewReader(body)) + }() return nil } diff --git a/commands/account/recover.go b/commands/account/recover.go index 8158af61..165e88e8 100644 --- a/commands/account/recover.go +++ b/commands/account/recover.go @@ -8,6 +8,7 @@ import ( "path/filepath" "git.sr.ht/~rjarry/aerc/commands" + "git.sr.ht/~rjarry/aerc/logging" "git.sr.ht/~rjarry/aerc/models" "git.sr.ht/~rjarry/aerc/widgets" "git.sr.ht/~sircmpwn/getopt" @@ -111,7 +112,11 @@ func (Recover) Execute(aerc *widgets.Aerc, args []string) error { tab.Name = subject tab.Content.Invalidate() }) - go composer.AppendContents(bytes.NewReader(data)) + go func() { + defer logging.PanicHandler() + + composer.AppendContents(bytes.NewReader(data)) + }() // remove file if force flag is set if force { -- cgit