From d13361b8dbaeba9b900108b26b56bf56fce9be26 Mon Sep 17 00:00:00 2001 From: Syed Fasiuddin Date: Sat, 12 Oct 2024 21:50:52 +0530 Subject: mbox: handle invalid URL scheme in command line Currently if `aerc mbox:..` is used on the command line with an invalid URL schema such as `aerc mbox:~/mbox`, it tries to open "nothing" and fails, instead of letting the user know that the URL scheme (command usage) is wrong. This commit silently handles such wrong URL schemes. Fixes: https://todo.sr.ht/~rjarry/aerc/281 Signed-off-by: Syed Fasiuddin Acked-by: Tim Culverhouse Tested-by: Koni Marti --- worker/mbox/worker.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/worker/mbox/worker.go b/worker/mbox/worker.go index 72a44368..e8b3fa3e 100644 --- a/worker/mbox/worker.go +++ b/worker/mbox/worker.go @@ -59,6 +59,14 @@ func (w *mboxWorker) handleMessage(msg types.WorkerMessage) error { reterr = err break } + if u.Host == "" && u.Path == "" { + u, err = url.Parse("mbox://" + u.Opaque) + if err != nil { + reterr = err + break + } + } + var dir string if u.Host == "~" { home, err := os.UserHomeDir() -- cgit