lint: homogenize operations and minor fixes (gocritic)

Apply GoDoc comment policy (comments for humans should have a space
after the //; machine-readable comments shouldn't)

Use strings.ReplaceAll instead of strings.Replace when appropriate

Remove if/else chains by replacing them with switches

Use short assignment/increment notation

Replace single case switches with if statements

Combine else and if when appropriate

Signed-off-by: Moritz Poldrack <moritz@poldrack.dev>
Acked-by: Robin Jarry <robin@jarry.cc>

1 files changed, 4 insertions, 3 deletions

diff --git a/worker/maildir/search.go b/worker/maildir/search.go
index 7a8ba0e0..6260deb4 100644
--- a/worker/maildir/search.go
+++ b/worker/maildir/search.go
@@ -61,11 +61,12 @@ func parseSearch(args []string) (*searchCriteria, error) {
 			text = true
 		}
 	}
-	if text {
+	switch {
+	case text:
 		criteria.Text = args[optind:]
-	} else if body {
+	case body:
 		criteria.Body = args[optind:]
-	} else {
+	default:
 		for _, arg := range args[optind:] {
 			criteria.Header.Add("Subject", arg)
 		}