diff options
| author | Tim Culverhouse <tim@timculverhouse.com> | 2023-04-28 09:43:36 -0500 |
|---|---|---|
| committer | Robin Jarry <robin@jarry.cc> | 2023-04-28 20:58:24 +0200 |
| commit | ef4504e6baf513713779b1e1af40848e746e704b (patch) | |
| tree | cd8006d32dcc199e2fd825e51fedd1aed951064e /worker/maildir/container.go | |
| parent | e02479ad9ab802d5ab8da1ea614a579fc126ece6 (diff) | |
| download | aerc-ef4504e6baf513713779b1e1af40848e746e704b.tar.gz | |
maildir: fix handling of FSEvents
Maildir uses a filesystem watcher to watch the currently selected
directory for changes, updating the UI as necessary. Not all changes get
updated based on the current logic. Send a MessageInfo if the event was
a Rename. Send a MessagesDeleted if the event was a Remove. Tell the UI
to refetch the list if the event was a Create.
Note: This leads to some unnecessary fetching in the UI, as renames also
come with a Create event in most cases. Koni suggested sending the
MessageInfo and having the UI perform a binary search and inserting the
message in the proper position. This is optimization is left out of this
series, with a TODO left in the code.
Fixes: https://todo.sr.ht/~rjarry/aerc/171
Fixes: 91ac21ac6155 ("msgstore: fetch message list based on OpenDirectory msg")
Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
Acked-by: Robin Jarry <robin@jarry.cc>
Diffstat (limited to 'worker/maildir/container.go')
| -rw-r--r-- | worker/maildir/container.go | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/worker/maildir/container.go b/worker/maildir/container.go index f9fb507b..946de74d 100644 --- a/worker/maildir/container.go +++ b/worker/maildir/container.go @@ -93,6 +93,15 @@ func (c *Container) Message(d maildir.Dir, uid uint32) (*Message, error) { uid, d) } +func (c *Container) MessageFromKey(d maildir.Dir, key string) *Message { + uid := c.uids.GetOrInsert(key) + return &Message{ + dir: d, + uid: uid, + key: key, + } +} + // DeleteAll deletes a set of messages by UID and returns the subset of UIDs // which were successfully deleted, stopping upon the first error. func (c *Container) DeleteAll(d maildir.Dir, uids []uint32) ([]uint32, error) { |