compose: fix deadlock when editor errors after :reply -c

When the message viewer is open and running :reply -c, if the editor
exits with an error (e.g. vim :cq), the compose tab is not closed and
aerc does not register input anymore.

This happens because the composer is closed twice. Once explicitly, and
a second time by RemoveTab. This causes to open two viewers on the same
message at the same time.

Here is the deadlock stack trace:

  goroutine 149 [sync.Mutex.Lock]:
  runtime.gopark()
          runtime/proc.go:398
  ...
  sync.(*Mutex).Lock(...)
          sync/mutex.go:90
  git.sr.ht/~rjarry/aerc/app.(*Composer).Show()
          git.sr.ht/~rjarry/aerc/app/compose.go:793
  git.sr.ht/~rjarry/aerc/lib/ui.(*Tabs).selectPriv()
          git.sr.ht/~rjarry/aerc/lib/ui/tab.go:171
  git.sr.ht/~rjarry/aerc/lib/ui.(*Tabs).Add()
          git.sr.ht/~rjarry/aerc/lib/ui/tab.go:75
  git.sr.ht/~rjarry/aerc/app.(*Aerc).NewTab()
          git.sr.ht/~rjarry/aerc/app/aerc.go:481
  git.sr.ht/~rjarry/aerc/app.NewTab(...)
          git.sr.ht/~rjarry/aerc/app/app.go:60
  git.sr.ht/~rjarry/aerc/commands/account.ViewMessage.Execute.func1()
          git.sr.ht/~rjarry/aerc/commands/account/view.go:71
  git.sr.ht/~rjarry/aerc/lib.NewMessageStoreView.func1()
          git.sr.ht/~rjarry/aerc/lib/messageview.go:79
  git.sr.ht/~rjarry/aerc/lib.NewMessageStoreView()
          git.sr.ht/~rjarry/aerc/lib/messageview.go:123
  git.sr.ht/~rjarry/aerc/commands/account.ViewMessage.Execute()
          git.sr.ht/~rjarry/aerc/commands/account/view.go:52
  git.sr.ht/~rjarry/aerc/commands/msg.reply.Execute.func1.1()
          git.sr.ht/~rjarry/aerc/commands/msg/reply.go:191
  git.sr.ht/~rjarry/aerc/app.(*Composer).Close()
          git.sr.ht/~rjarry/aerc/app/compose.go:714
  git.sr.ht/~rjarry/aerc/app.(*Composer).termClosed()
          git.sr.ht/~rjarry/aerc/app/compose.go:1189
  git.sr.ht/~rjarry/aerc/app.(*Terminal).closeErr()
          git.sr.ht/~rjarry/aerc/app/terminal.go:69
  git.sr.ht/~rjarry/aerc/app.(*Terminal).Close(...)
          git.sr.ht/~rjarry/aerc/app/terminal.go:46
  git.sr.ht/~rjarry/aerc/app.(*Terminal).HandleEvent()
          git.sr.ht/~rjarry/aerc/app/terminal.go:174
  git.sr.ht/~rockorager/tcell-term.(*VT).Start.func1()
          git.sr.ht/~rockorager/tcell-term@v0.10.0/vt.go:175
  created by git.sr.ht/~rockorager/tcell-term.(*VT).Start in goroutine 1
          git.sr.ht/~rockorager/tcell-term@v0.10.0/vt.go:165 +0x38d

Fixes: https://todo.sr.ht/~rjarry/aerc/216
Reported-by: Karel Balej <balejk@matfyz.cz>
Signed-off-by: Robin Jarry <robin@jarry.cc>
Tested-by: Karel Balej <balejk@matfyz.cz>

0 files changed, 0 insertions, 0 deletions