aboutsummaryrefslogtreecommitdiffstats
path: root/config
diff options
context:
space:
mode:
authorTim Culverhouse <tim@timculverhouse.com>2022-07-03 10:11:13 -0500
committerRobin Jarry <robin@jarry.cc>2022-07-03 21:32:24 +0200
commit4240f1fbfd095724bcbb0ea49cfa561c973ba6ce (patch)
treedbece5561d81a56eb106d0f6fe2019fb6d41e9c9 /config
parentd45c07eb6a0955a24efec7bd915ba19746042778 (diff)
downloadaerc-4240f1fbfd095724bcbb0ea49cfa561c973ba6ce.tar.gz
perf: reduce calls to GetUiConfig
GetUiConfig was being called many times, and came up as a high CPU user in a cpuprofile. Every call would merge a UIConfig, which is a costly operation. Ideally, we would only need to have a config for every account X every directory. We also have a context for subjects. This patch stores all FOLDER and ACCOUNT level configs and reuses those merged objects. The SUBJECT contexts are not stored in favor of merging on-the-go, with a TODO comment to deprecate that feature and implement a better per-message styling option. I suspect this feature is not used very much. Before applying this patch with my setup, GetUiConfig is called 1159 times just to open aerc. After applying, this is reduced to 37. Signed-off-by: Tim Culverhouse <tim@timculverhouse.com> Acked-by: Robin Jarry <robin@jarry.cc>
Diffstat (limited to 'config')
-rw-r--r--config/config.go4
1 files changed, 4 insertions, 0 deletions
diff --git a/config/config.go b/config/config.go
index ee8dc6a8..8a243c3a 100644
--- a/config/config.go
+++ b/config/config.go
@@ -1027,6 +1027,10 @@ func (config AercConfig) GetUiConfig(params map[ContextType]string) *UIConfig {
return &baseUi
}
+func (config *AercConfig) GetContextualUIConfigs() []UIConfigContext {
+ return config.ContextualUis
+}
+
func (uiConfig UIConfig) GetStyle(so StyleObject) tcell.Style {
return uiConfig.style.Get(so)
}