smtp: replace smtp-starttls with schema option

The "smtp-starttls" options is now ignored in favor of more detailed
schema specification, similarly to IMAP.

Fixes: https://todo.sr.ht/~rjarry/aerc/149
Signed-off-by: Marcin Serwin <marcin.serwin0@protonmail.com>
Acked-by: Robin Jarry <robin@jarry.cc>

1 files changed, 10 insertions, 0 deletions

diff --git a/config/accounts.go b/config/accounts.go
index 8aadb329..bacd7e39 100644
--- a/config/accounts.go
+++ b/config/accounts.go
@@ -161,6 +161,16 @@ func parseAccounts(root string, accts []string) error {
 				account.Params[key] = val
 			}
 		}
+		if _, ok := account.Params["smtp-starttls"]; ok {
+			Warnings = append(Warnings, Warning{
+				Title: "accounts.conf: smtp-starttls is deprecated",
+				Body: `
+SMTP connections now use STARTTLS by default and the smtp-starttls setting is ignored.
+
+If you want to disable STARTTLS, append +insecure to the schema.
+`,
+			})
+		}
 		if account.Source == "" {
 			return fmt.Errorf("Expected source for account %s", _sec)
 		}