aboutsummaryrefslogtreecommitdiffstats
path: root/commands
diff options
context:
space:
mode:
authorReto Brunner <reto@labrat.space>2021-02-26 22:10:26 +0100
committerReto Brunner <reto@labrat.space>2021-02-26 22:14:58 +0100
commit8b4f2d148c8519326f306fd14ba872d7cb3101c6 (patch)
tree278576aa1e034c5cb2c5df9a1579661c3edacfee /commands
parentfda424bebc6dedbbcbffe4d330accc70d081b478 (diff)
downloadaerc-8b4f2d148c8519326f306fd14ba872d7cb3101c6.tar.gz
Fix linter warnings
* Remove redundant return (code was never reached) * Remove redundant type information * Rename unused function parameters to "_"
Diffstat (limited to 'commands')
-rw-r--r--commands/msg/delete.go1
-rw-r--r--commands/msg/forward.go2
-rw-r--r--commands/msg/unsubscribe_test.go12
3 files changed, 7 insertions, 8 deletions
diff --git a/commands/msg/delete.go b/commands/msg/delete.go
index baa5011f..677a666d 100644
--- a/commands/msg/delete.go
+++ b/commands/msg/delete.go
@@ -97,7 +97,6 @@ func findNextNonDeleted(deleted []uint32, store *lib.MessageStore) *models.Messa
}
return next
}
- return nil // Never reached
}
func contains(uids []uint32, uid uint32) bool {
diff --git a/commands/msg/forward.go b/commands/msg/forward.go
index 475d6805..edade6d1 100644
--- a/commands/msg/forward.go
+++ b/commands/msg/forward.go
@@ -132,7 +132,7 @@ func (forward) Execute(aerc *widgets.Aerc, args []string) error {
return
}
composer.AddAttachment(tmpFileName)
- composer.OnClose(func(composer *widgets.Composer) {
+ composer.OnClose(func(_ *widgets.Composer) {
os.RemoveAll(tmpDir)
})
})
diff --git a/commands/msg/unsubscribe_test.go b/commands/msg/unsubscribe_test.go
index e4e6f25e..d34efb1a 100644
--- a/commands/msg/unsubscribe_test.go
+++ b/commands/msg/unsubscribe_test.go
@@ -10,19 +10,19 @@ func TestParseUnsubscribe(t *testing.T) {
expected []string
}
cases := []*tc{
- &tc{"", []string{}},
- &tc{"invalid", []string{}},
- &tc{"<https://example.com>, <http://example.com>", []string{
+ {"", []string{}},
+ {"invalid", []string{}},
+ {"<https://example.com>, <http://example.com>", []string{
"https://example.com", "http://example.com",
}},
- &tc{"<https://example.com> is a URL", []string{
+ {"<https://example.com> is a URL", []string{
"https://example.com",
}},
- &tc{"<mailto:user@host?subject=unsubscribe>, <https://example.com>",
+ {"<mailto:user@host?subject=unsubscribe>, <https://example.com>",
[]string{
"mailto:user@host?subject=unsubscribe", "https://example.com",
}},
- &tc{"<>, <https://example> ", []string{
+ {"<>, <https://example> ", []string{
"", "https://example",
}},
}