app: export global functions

The single Aerc object is passed around in almost all command functions.
This hinders readability.

Store the single Aerc instance as a global variable. Export public
functions from the app package to access methods of that object. Remove
all explicit references to *app.Aerc and replace them with calls to
these functions. For references to private/unexported fields and
functions from within the app package, directly access the global aerc
object.

Signed-off-by: Robin Jarry <robin@jarry.cc>
Acked-by: Moritz Poldrack <moritz@poldrack.dev>

1 files changed, 3 insertions, 4 deletions

diff --git a/commands/msg/toggle-threads.go b/commands/msg/toggle-threads.go
index 0b85e510..1d38685a 100644
--- a/commands/msg/toggle-threads.go
+++ b/commands/msg/toggle-threads.go
@@ -3,7 +3,6 @@ package msg
 import (
 	"errors"
 
-	"git.sr.ht/~rjarry/aerc/app"
 	"git.sr.ht/~rjarry/aerc/lib/state"
 	"git.sr.ht/~rjarry/aerc/lib/ui"
 )
@@ -18,15 +17,15 @@ func (ToggleThreads) Aliases() []string {
 	return []string{"toggle-threads"}
 }
 
-func (ToggleThreads) Complete(aerc *app.Aerc, args []string) []string {
+func (ToggleThreads) Complete(args []string) []string {
 	return nil
 }
 
-func (ToggleThreads) Execute(aerc *app.Aerc, args []string) error {
+func (ToggleThreads) Execute(args []string) error {
 	if len(args) != 1 {
 		return errors.New("Usage: toggle-threads")
 	}
-	h := newHelper(aerc)
+	h := newHelper()
 	acct, err := h.account()
 	if err != nil {
 		return err