app: export global functions

The single Aerc object is passed around in almost all command functions.
This hinders readability.

Store the single Aerc instance as a global variable. Export public
functions from the app package to access methods of that object. Remove
all explicit references to *app.Aerc and replace them with calls to
these functions. For references to private/unexported fields and
functions from within the app package, directly access the global aerc
object.

Signed-off-by: Robin Jarry <robin@jarry.cc>
Acked-by: Moritz Poldrack <moritz@poldrack.dev>

1 files changed, 3 insertions, 4 deletions

diff --git a/commands/msg/mark.go b/commands/msg/mark.go
index 27677609..eeaa5485 100644
--- a/commands/msg/mark.go
+++ b/commands/msg/mark.go
@@ -3,7 +3,6 @@ package msg
 import (
 	"fmt"
 
-	"git.sr.ht/~rjarry/aerc/app"
 	"git.sr.ht/~sircmpwn/getopt"
 )
 
@@ -17,12 +16,12 @@ func (Mark) Aliases() []string {
 	return []string{"mark", "unmark", "remark"}
 }
 
-func (Mark) Complete(aerc *app.Aerc, args []string) []string {
+func (Mark) Complete(args []string) []string {
 	return nil
 }
 
-func (Mark) Execute(aerc *app.Aerc, args []string) error {
-	h := newHelper(aerc)
+func (Mark) Execute(args []string) error {
+	h := newHelper()
 	OnSelectedMessage := func(fn func(uint32)) error {
 		if fn == nil {
 			return fmt.Errorf("no operation selected")