diff options
| author | Moritz Poldrack <git@moritz.sh> | 2022-07-31 14:32:48 +0200 |
|---|---|---|
| committer | Robin Jarry <robin@jarry.cc> | 2022-08-04 21:58:01 +0200 |
| commit | 978d35d356e8752bdd272884df48a6289d88b40a (patch) | |
| tree | 3910243e688ef503159d07ce44b22cfea5d6c6fd /commands/ct.go | |
| parent | c882cf9960be691fe55617b87cdfcfbabd5d5557 (diff) | |
| download | aerc-978d35d356e8752bdd272884df48a6289d88b40a.tar.gz | |
lint: homogenize operations and minor fixes (gocritic)
Apply GoDoc comment policy (comments for humans should have a space
after the //; machine-readable comments shouldn't)
Use strings.ReplaceAll instead of strings.Replace when appropriate
Remove if/else chains by replacing them with switches
Use short assignment/increment notation
Replace single case switches with if statements
Combine else and if when appropriate
Signed-off-by: Moritz Poldrack <moritz@poldrack.dev>
Acked-by: Robin Jarry <robin@jarry.cc>
Diffstat (limited to 'commands/ct.go')
| -rw-r--r-- | commands/ct.go | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/commands/ct.go b/commands/ct.go index 092d9739..3bd3428e 100644 --- a/commands/ct.go +++ b/commands/ct.go @@ -40,15 +40,16 @@ func (ChangeTab) Execute(aerc *widgets.Aerc, args []string) error { } else { n, err := strconv.Atoi(joinedArgs) if err == nil { - if strings.HasPrefix(joinedArgs, "+") { + switch { + case strings.HasPrefix(joinedArgs, "+"): for ; n > 0; n-- { aerc.NextTab() } - } else if strings.HasPrefix(joinedArgs, "-") { + case strings.HasPrefix(joinedArgs, "-"): for ; n < 0; n++ { aerc.PrevTab() } - } else { + default: ok := aerc.SelectTabIndex(n) if !ok { return errors.New( |