compose: improve error handling

On error, return to the caller instead of logging a warning and trying
to continue.

Signed-off-by: Robin Jarry <robin@jarry.cc>
Tested-by: Bence Ferdinandy <bence@ferdinandy.com>
Tested-by: Koni Marti <koni.marti@gmail.com>

1 files changed, 8 insertions, 2 deletions

diff --git a/commands/compose/edit.go b/commands/compose/edit.go
index 7a61f77a..6f877346 100644
--- a/commands/compose/edit.go
+++ b/commands/compose/edit.go
@@ -24,8 +24,14 @@ func (Edit) Execute(aerc *widgets.Aerc, args []string) error {
 	if len(args) != 1 {
 		return errors.New("Usage: edit")
 	}
-	composer, _ := aerc.SelectedTabContent().(*widgets.Composer)
-	composer.ShowTerminal()
+	composer, ok := aerc.SelectedTabContent().(*widgets.Composer)
+	if !ok {
+		return errors.New("only valid while composing")
+	}
+	err := composer.ShowTerminal()
+	if err != nil {
+		return err
+	}
 	composer.FocusTerminal()
 	return nil
 }