app: export global functions

The single Aerc object is passed around in almost all command functions.
This hinders readability.

Store the single Aerc instance as a global variable. Export public
functions from the app package to access methods of that object. Remove
all explicit references to *app.Aerc and replace them with calls to
these functions. For references to private/unexported fields and
functions from within the app package, directly access the global aerc
object.

Signed-off-by: Robin Jarry <robin@jarry.cc>
Acked-by: Moritz Poldrack <moritz@poldrack.dev>

1 files changed, 3 insertions, 3 deletions

diff --git a/commands/cd.go b/commands/cd.go
index 67891589..ded325d5 100644
--- a/commands/cd.go
+++ b/commands/cd.go
@@ -21,7 +21,7 @@ func (ChangeDirectory) Aliases() []string {
 	return []string{"cd"}
 }
 
-func (ChangeDirectory) Complete(aerc *app.Aerc, args []string) []string {
+func (ChangeDirectory) Complete(args []string) []string {
 	path := strings.Join(args, " ")
 	completions := CompletePath(path)
 
@@ -36,7 +36,7 @@ func (ChangeDirectory) Complete(aerc *app.Aerc, args []string) []string {
 	return dirs
 }
 
-func (ChangeDirectory) Execute(aerc *app.Aerc, args []string) error {
+func (ChangeDirectory) Execute(args []string) error {
 	if len(args) < 1 {
 		return errors.New("Usage: cd [directory]")
 	}
@@ -57,7 +57,7 @@ func (ChangeDirectory) Execute(aerc *app.Aerc, args []string) error {
 	target = xdg.ExpandHome(target)
 	if err := os.Chdir(target); err == nil {
 		previousDir = cwd
-		aerc.UpdateStatus()
+		app.UpdateStatus()
 	}
 	return err
 }