diff options
| author | delitako <delitako@delitako.xyz> | 2024-01-25 22:50:14 -0600 |
|---|---|---|
| committer | Robin Jarry <robin@jarry.cc> | 2024-01-26 20:27:08 +0100 |
| commit | 936d519a67301bd78a4d737dc47234e3769e639f (patch) | |
| tree | 701dc21c0551d4f020cb1c339ba0270c1525c2a7 /app/app.go | |
| parent | 58585e0a8e264f7a5500b3f24b0b319d59f36882 (diff) | |
| download | aerc-936d519a67301bd78a4d737dc47234e3769e639f.tar.gz | |
tabs: optimize switching by offsets
I imagine no sane user requires aerc to correctly handle commands like
`:next-tab 1000000000`, but I tried anyway and it froze aerc while
also eating up many GBs of system memory. This behavior is not ideal,
so I improved it.
This commit adds functions for selecting a tab at an offset from the
currently-selected tab and changes the next-tab, prev-tab, and
change-tab commands to use these functions instead of looping.
Signed-off-by: delitako <delitako@delitako.xyz>
Tested-by: Thomas Böhler <witcher@wiredspace.de>
Reviewed-by: Thomas Böhler <witcher@wiredspace.de>
Acked-by: Robin Jarry <robin@jarry.cc>
Diffstat (limited to 'app/app.go')
| -rw-r--r-- | app/app.go | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -55,6 +55,7 @@ func SelectPreviousTab() bool { return aerc.SelectPrev func SelectedTab() *ui.Tab { return aerc.SelectedTab() } func SelectedTabContent() ui.Drawable { return aerc.SelectedTabContent() } func SelectTabIndex(index int) bool { return aerc.SelectTabIndex(index) } +func SelectTabAtOffset(offset int) { aerc.SelectTabAtOffset(offset) } func RemoveTab(tab ui.Drawable, closeContent bool) { aerc.RemoveTab(tab, closeContent) } func NewTab(clickable ui.Drawable, name string) *ui.Tab { return aerc.NewTab(clickable, name) } func ReplaceTab(tabSrc ui.Drawable, tabTarget ui.Drawable, name string, closeSrc bool) { |