logging: fix race condition in startup

If a panic occurs in one of the workers, it can happen after the UI was
initialised, but before the cleanup function has been registered. With
this the start of the worker loops is deferred until the cleanup routine
was registered.

Signed-off-by: Moritz Poldrack <git@moritz.sh>

1 files changed, 4 insertions, 1 deletions

diff --git a/aerc.go b/aerc.go
index aa82f98f..9d93a501 100644
--- a/aerc.go
+++ b/aerc.go
@@ -166,11 +166,13 @@ func main() {
 		ui   *libui.UI
 	)
 
+	deferLoop := make(chan struct{})
+
 	aerc = widgets.NewAerc(conf, logger, func(cmd []string) error {
 		return execCommand(aerc, ui, cmd)
 	}, func(cmd string) []string {
 		return getCompletions(aerc, cmd)
-	}, &commands.CmdHistory)
+	}, &commands.CmdHistory, deferLoop)
 
 	ui, err = libui.Initialize(aerc)
 	if err != nil {
@@ -180,6 +182,7 @@ func main() {
 	logging.UICleanup = func() {
 		ui.Close()
 	}
+	close(deferLoop)
 
 	if conf.Ui.MouseEnabled {
 		ui.EnableMouse()