diff options
| author | Tim Culverhouse <tim@timculverhouse.com> | 2022-10-06 11:46:44 -0500 |
|---|---|---|
| committer | Robin Jarry <robin@jarry.cc> | 2022-10-07 10:51:53 +0200 |
| commit | 049c72393a26806f2e7408075a48849467262c00 (patch) | |
| tree | f3f62f6162930a6ead21b613c44dadd81c83a73e /CHANGELOG.md | |
| parent | a49caf96b5419150989c2517fdb8f0aca7cfe92d (diff) | |
| download | aerc-049c72393a26806f2e7408075a48849467262c00.tar.gz | |
invalidatable: always mark ui as dirty OnInvalidate
The Invalidatable struct is designed so that a widget can have a
callback function ran when it is Invalidated. This is used to cascade up
the widget tree, marking things as Invalid along the way so that only
Invalid widgets are drawn. However, this is only implemented at the grid
cell level for checks if the cell is invalidated -- and the grid cells
are never set back to a "valid" state. The effect of this is that no
matter what is invalidated, the entire UI gets drawn again.
The calling through the Invalidate callbacks creates *several* race
conditions, as Invalidate is called from several different goroutines,
and many widgets call invalidate on their parent or children.
Tcell has optimizations to only rerender screen cells that have changed
their rune and style. The only performance penalty by redrawing the
entire screen for aerc is the operations *within the aerc draw methods*.
Most of these are not expensive and have relatively no impact on
performance.
Skip all of the OnInvalidates, and directly invalidate the UI when
DoInvalidate is called by a widget. This reduces data races, and
simplifies the widget redraw logic signficantly.
Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
Acked-by: Robin Jarry <robin@jarry.cc>
Diffstat (limited to 'CHANGELOG.md')
| -rw-r--r-- | CHANGELOG.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 0739dcd0..f3ab262e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -37,6 +37,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). `accounts.conf`. - Mouse support for embedded editors when `mouse-enabled=true`. - Numerous race conditions related to event handling order +- Numerous race conditions related to OnInvalidate calls ## [0.12.0](https://git.sr.ht/~rjarry/aerc/refs/0.12.0) - 2022-09-01 |