aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRobin Jarry <robin@jarry.cc>2023-03-15 15:47:17 +0100
committerRobin Jarry <robin@jarry.cc>2023-03-15 16:22:03 +0100
commit683b06105ef977e9361c359511457bc63d375705 (patch)
tree82cbe17774d41425f10e4b6f2f27073f83c7bb9f
parentc15c91e609c242feeaeb23984cec8a9f64607061 (diff)
downloadaerc-683b06105ef977e9361c359511457bc63d375705.tar.gz
move/archive: make sure to close existing viewer
When running :move or :archive with a message viewer opened, the viewer is never closed properly. This leads to resources leak (pager processes left running). Fix that. Reported-by: Kirill Chibisov <contact@kchibisov.com> Signed-off-by: Robin Jarry <robin@jarry.cc> Tested-by: Kirill Chibisov <contact@kchibisov.com>
-rw-r--r--commands/msg/move.go2
1 files changed, 2 insertions, 0 deletions
diff --git a/commands/msg/move.go b/commands/msg/move.go
index 6e77a88c..fc35c41b 100644
--- a/commands/msg/move.go
+++ b/commands/msg/move.go
@@ -93,8 +93,10 @@ func handleDone(
mv, isMsgView := h.msgProvider.(*widgets.MessageViewer)
switch {
case isMsgView && !config.Ui.NextMessageOnDelete:
+ mv.Close()
aerc.RemoveTab(h.msgProvider)
case isMsgView:
+ mv.Close()
if next == nil {
aerc.RemoveTab(h.msgProvider)
acct.Messages().Select(-1)