diff options
| author | Tim Culverhouse <tim@timculverhouse.com> | 2022-10-19 12:48:02 -0500 |
|---|---|---|
| committer | Robin Jarry <robin@jarry.cc> | 2022-10-19 21:01:55 +0200 |
| commit | ee964ad6b0bd8ee42e903e25b75d9985dc2ff40e (patch) | |
| tree | 61d28d5363384ba503c56aab3cd9fdcfa8d1fcef | |
| parent | 3687b1814990bcbf75cc1d98910c3e3125d9e192 (diff) | |
| download | aerc-ee964ad6b0bd8ee42e903e25b75d9985dc2ff40e.tar.gz | |
command/help: remove helpClose function
The helpClose function is used to call UpdateScreen on MessageViewer,
which has the effect of invalidating and redrawing the message view.
This logic is redundant with the addition of tcell-term and the main
event loop.
Remove the helpClose calls. Remove the UpdateScreen methods from
messageviewer: those functions are only used by the helpClose function.
Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
Acked-by: Koni Marti <koni.marti@gmail.com>
| -rw-r--r-- | commands/help.go | 7 | ||||
| -rw-r--r-- | widgets/msgviewer.go | 20 |
2 files changed, 0 insertions, 27 deletions
diff --git a/commands/help.go b/commands/help.go index 9e1d1140..498f9bce 100644 --- a/commands/help.go +++ b/commands/help.go @@ -50,7 +50,6 @@ func (Help) Execute(aerc *widgets.Aerc, args []string) error { aerc.HumanReadableBindings(), aerc.SelectedAccountUiConfig(), func(_ string) { - helpClose(aerc) aerc.CloseDialog() }, ), @@ -61,9 +60,3 @@ func (Help) Execute(aerc *widgets.Aerc, args []string) error { return TermCore(aerc, []string{"term", "man", page}) } - -func helpClose(aerc *widgets.Aerc) { - if content, ok := aerc.SelectedTabContent().(*widgets.MessageViewer); ok { - content.UpdateScreen() - } -} diff --git a/widgets/msgviewer.go b/widgets/msgviewer.go index f8b2816f..7365dc53 100644 --- a/widgets/msgviewer.go +++ b/widgets/msgviewer.go @@ -387,22 +387,6 @@ func (mv *MessageViewer) Close() error { return nil } -func (mv *MessageViewer) UpdateScreen() { - if mv.switcher == nil { - return - } - parts := mv.switcher.parts - selected := mv.switcher.selected - if selected < 0 { - return - } - if len(parts) > 0 && selected < len(parts) { - if part := parts[selected]; part != nil { - part.UpdateScreen() - } - } -} - func (ps *PartSwitcher) Invalidate() { ui.Invalidate() } @@ -638,10 +622,6 @@ func (pv *PartViewer) SetSource(reader io.Reader) { pv.attemptCopy() } -func (pv *PartViewer) UpdateScreen() { - pv.Invalidate() -} - func (pv *PartViewer) attemptCopy() { if pv.source == nil || pv.filter == nil || |