diff options
| author | Robin Jarry <robin@jarry.cc> | 2022-07-21 11:47:30 +0200 |
|---|---|---|
| committer | Robin Jarry <robin@jarry.cc> | 2022-07-23 21:51:47 +0200 |
| commit | 5dec1f09b1d4a642aff1f711c44eb12e61b6129c (patch) | |
| tree | ec0ceb3a3e5c4a50f24ba0e0973878cfa36e3e9c | |
| parent | 52f7d3f900e4c0e3ee8458c9479859924901a3aa (diff) | |
| download | aerc-5dec1f09b1d4a642aff1f711c44eb12e61b6129c.tar.gz | |
imap: fix error when server returns a message without body section
When opening unread emails from certain people (I won't name any names,
sorry), an annoying error message is displayed on the status line:
could not get section &imap.BodySectionName{BodyPartName:
imap.BodyPartName{Specifier:"", Path:[]int(nil), Fields:[]string(nil),
NotFields:false}, Peek:false, Partial:[]int(nil), value}
This does not occur for already read messages. This issue is similar to
the one that was fixed in commit 8ed95b0d2ad2 ("imap: avoid crash when
replying to unread message").
This happens because the flags are updated in the callback that receives
the message itself. It causes the flag update to arrive in the same
channel/request. Ignore the messages that have an empty body (i.e. only
containing flag updates). This is inherently racy but there seems no way
to get rid of these extra messages.
Signed-off-by: Robin Jarry <robin@jarry.cc>
Acked-by: Koni Marti <koni.marti@gmail.com>
| -rw-r--r-- | worker/imap/fetch.go | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/worker/imap/fetch.go b/worker/imap/fetch.go index 7d7b72fe..cf27e382 100644 --- a/worker/imap/fetch.go +++ b/worker/imap/fetch.go @@ -158,6 +158,10 @@ func (imapw *IMAPWorker) handleFetchFullMessages( } imapw.handleFetchMessages(msg, msg.Uids, items, func(_msg *imap.Message) error { + if len(_msg.Body) == 0 { + // ignore duplicate messages with only flag updates + return nil + } r := _msg.GetBody(section) if r == nil { return fmt.Errorf("could not get section %#v", section) |