From 63817ba9dae2cb64b21ab59279def64572a6459a Mon Sep 17 00:00:00 2001 From: Jake Hunsaker Date: Tue, 11 May 2021 22:44:57 -0400 Subject: [Policy] Correct and clarify https upload internals The python requests module does not provide actual support for streaming, that is provided by requests-toolchain. The support in requests is for easy multipart uploads. The internal methods and variables for https uploads within `Policy` however revolve around streaming enablement, but don't actually influence the use of streaming or not. This was due to placeholders during development just being carried forward rather than corrected before merge. This was largely forgotten about, until recent reports of upload issues for user-provided endpoints. This commit serves to correct the language around the currently supported https upload functionality. That is, we either use a 'put' or 'post' based on the loaded policy defaults. Further, allow users to control this setting with a new `--upload-method` option. This will allow users to specify upload urls that may require the opposite HTTP method than what the policy defaults dictate. Related: #2497 Signed-off-by: Jake Hunsaker --- man/en/sos-report.1 | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'man') diff --git a/man/en/sos-report.1 b/man/en/sos-report.1 index a6d247b4..1e626e09 100644 --- a/man/en/sos-report.1 +++ b/man/en/sos-report.1 @@ -362,6 +362,13 @@ be used provided all other required values (case number, upload user) are provid Specify a directory to upload to, if one is not specified by a vendor default location or if your destination server does not allow writes to '/'. .TP +.B \--upload-method METHOD +Specify the HTTP method to use for uploading to the provided --upload-url. Valid +values are 'auto' (default), 'put', or 'post'. The use of 'auto' will default to +the method required by the policy-default upload location, if one exists. + +This option has no effect on upload methods other than HTTPS. +.TP .B \--experimental Enable plugins marked as experimental. Experimental plugins may not have been tested for this port or may still be under active development. -- cgit